feat(jupyter-datascience-notebooks): add a new template jupyter-datascience-notebooks - #5
feat(jupyter-datascience-notebooks): add a new template jupyter-datascience-notebooks#5jcbhmr merged 15 commits into
Conversation
There was a problem hiding this comment.
🥇 Looks good enough to merge! 👍 More stuff can be added in the future (like better docs, authors/maintainers names, better comments, etc.). I think this is a good first template.
I know you mentioned something about "what information should go in the NOTES.md" somewhere, so you might be interested in #8
|
Thanks for the review. |
Good attitude to take. 🎖 I appreciate your counterweight to my zeal 💕 |
|
It has become apparent that some configuration changes are needed in linter CI. |
This PR would... (checkboxes track draft progress) - [x] Add a header image - [x] Make sure the under construction banner stays there for a bit while longer (until at least #5 is merged) - [x] Try to be original (right now heavily inspired by @jcbhmr's previous contributions to https://github.com/devcontainers-contrib/templates/blob/main/README.md - [x] Add instructions on _how to use_ these templates - [x] Add a dev section with a gist of how to fix/add stuff - [x] Include a reference to the CONTRIBUTING.md - [x] Encourage existing community members who have possible devcontainer templates to reach out Other meta stuff: - [ ] Conform to commit convention? - [] Passes linting? --------- Co-authored-by: eitsupi <ts1s1andn@gmail.com>
| "numpy", | ||
| "pandas", | ||
| "tidyverse", | ||
| "much more" |
There was a problem hiding this comment.
I have a feeling they are not platforms, but are copied straight from the original template.......
There was a problem hiding this comment.
opened devcontainers/templates#145 because I remembered you saying something like "the devcontainers official people get paid to do this" so I figured might as well ask, right? cant hurt.
There was a problem hiding this comment.
Thanks for opening that!
I too don't think this field is currently being used for anything.
So we can keep this as it is for now.
|
@jcbhmr I think I have finished the work. If you look at it and it looks like there are no major problems, let's merge it and submit a PR to the index https://github.com/devcontainers/devcontainers.github.io. |
|
@jcbhmr CI worked and published successfully, should I send the PR to the index? |
|
@jcbhmr Any thoughts? |
|
Sounds great! 👍 |
2 participants
Closes #2
Add a template for the purpose of replacing the legacy template that is in https://github.com/microsoft/vscode-dev-containers/tree/main/containers/jupyter-datascience-notebooks.
And update some Lint settings of CI.