Repository navigation
fix(publish): approve the v20.1.12 publisher for organization settings - #5951
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
@coderabbitai review |
Contributor
Action not completed
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
devantler
commented
Nov 9, 2026
devantler
left a comment
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: 57cf9defdbb3a47c842c64b4b62c18a4a567b645
- CodeRabbit: refused the request at this head with "Review rate limited" / "Review limit reached" at 09:28Z (platform repository quota; next included review in about 15 minutes, per its summary comment).
- Codex: usage limit since 2026-11-09T06:06:37Z (review-lane health, verified 09:10Z).
- Cursor Bugbot: usage limit since 2026-11-09T06:09:46Z (review-lane health, verified 09:10Z).
Checked:
- The github-config matcher accepts exactly
56ceec67(the signer of the running 20.1.15 release, which reads Ready and SourceVerified live) ande6db1a4e(v20.1.12, verified as the commit devantler-tech/.github#884 pins). - The matcher is still anchored and full-length, and the regression covers the retired revision, abbreviated and suffixed SHAs, other issuers, organisations, repositories and workflows.
- Retiring
57310dc6is safe: Flux resolves only the newest settings release, and every release since #5900 deployed is signed by56ceec67. - Between
56ceec67ande6db1a4ethe compare API shows no change to the publishing workflow or its helper scripts, so only the signer identity moves. - The canonical-approvals TSV, its regression (219 passes locally) and the approved-revisions guard (6 consumers agree) are consistent, and the approved-surface line moves only for github-config.
Verdict: no P0/P1 findings
Contributor
✅
|
Contributor
✅
|
Contributor
Author
Readiness at
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A pending dependency update in the organization settings repository moves the organization settings publisher to a newer version. The platform only accepts settings releases signed by publisher versions it has approved, so that update cannot merge until this approval is deployed.
What
Approves the newer publisher alongside the one that signed the settings release running today, and retires an older approval that nothing running still depends on. The publishing workflow itself is unchanged between the two versions, so only the signer identity moves.
Fixes #5950