Repository navigation
fix(identity): clear golangci-lint findings in the Dex binary check - #5918
Merged
Merged
Conversation
Every platform pull request updated to main now fails the whole-repository golangci-lint step on these eight findings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
@coderabbitai full review |
Contributor
Action not completed
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 53 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
✅
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
devantler
commented
Nov 8, 2026
devantler
left a comment
devantler
left a comment
Contributor
Author
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable) at 30e087c
Reviewed commit: 30e087cd4500c4d1dbbadb5956bf71fd863c8d8d
Lane availability, read directly on 2026-11-08 ~03:14Z:
- CodeRabbit: refused the full-review request at this head at 02:52:55Z with "Review limit reached" for this repository; next included review stated as ~53 minutes later.
- Codex: usage limit since 2026-11-08T00:09Z (review-lane-health DOWN, maintainer-only).
- Cursor Bugbot: usage limit since 2026-11-08T01:32Z (review-lane-health DOWN, maintainer-only).
What I checked:
- Correctness. Every change is behaviour-preserving: the five unchecked
Close/Removecalls become explicit discards (same order of deferred cleanup, so the temp file is still removed before it is closed, as before), and the error textDex discarded its configured TLS floorbecomes lower-case to satisfy ST1005. The string is compared in two places (the deferred diagnostic filter innativeTLSFloorandTestNativeTLSFloorControls); both moved with the producer, and a repository-wide search finds no other consumer, so the weak-floor control still reaches the real protocol check. - Security. No change to what is executed, read or written; the bounded diagnostic still drops the fixture log only for the expected failure.
- Scope. Two files under
scripts/check-dex-binary, matching the eight golangci findings that make every updated platform PR fail Lint since #5909. - CI at this head: 37 checks pass, 26 skipped, none failing — including validate-go-project Lint, Test and Code Coverage.
Verdict: no P0/P1 findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Since the organization Go workflow started linting the whole repository, every pull request brought up to date with main fails its lint check on eight findings in the Dex binary check that landed earlier. Three unparked pull requests already hit it this morning.
What
Handle the ignored cleanup results and lower-case one error message, so lint passes again. The check behaves exactly as before.
No issue: trivial fix.