Skip to content

fix(storage): report known Talos allocation phases - #5803

Merged
devantler merged 1 commit into
mainfrom
codex/longhorn-block-phase-5782
Nov 3, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/longhorn-block-phase-5782

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The migration disk check hides several known allocation states, leaving an observed temporary disk state unexplained.

What

Report each known state clearly so the next migration step can use the observed evidence. Unknown states remain explicitly unknown.

Part of #5782

Keep unknown phases closed as other and exercise the native observer for every known phase. Part of #5782.
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

At 79ea64c, the new native-observer regression failed before the correction because six known Talos phases were all reported as other. It passes with the explicit known-phase mappings. The existing waiting/ready reports remain the same, and negative or future numeric phases remain other.

All three workflow-declared affected packages pass with race detection. Lint, formatting and whitespace checks pass. Correctness, security and simplification self-review found no remaining issue. This changes diagnostics only: no mutation capability, reset clearance, state qualification, native scope or permission changes. The published body passes its immediate readback check. Actual protected-main observation is still required after merge.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between e0c3ca5 and 79ea64c.

Files selected for processing: 2
  • internal/longhorninventory/block_layout.go
  • internal/longhorninventory/block_layout_test.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

CodeRabbit refused this request with a repository-scoped included-review limit at 03:13:42 UTC; its stated next availability is 03:25:42 UTC. No substantive current-head review was published, and the no-gate guard returned ADMIT. Continuing to the next review lane. The quota is not a review pass.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T03:16:21.603719Z 79ea64c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 79ea64c3d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Evaluated head 79ea64c: all 51 hosted check contexts are settled without failures, including the complete Go suite and CodeQL. The affected native-observer regression reproduced the hidden known phases before the correction and passes afterward. All affected race tests, lint, formatting and whitespace checks pass. No source, permission or reset-qualification guard changes.

Codex completed a clean current-head review, with summary #issuecomment-6594528846 and receipt #issuecomment-6594535136. The complete conversation, review objects, inline comments and threads contain no unresolved finding or maintainer instruction. CodeRabbit's repository-scoped quota was directly verified before advancing lanes; its quota is not a review pass. The body passes the seed/check/readback contract. Readable required gates pass; configured code-quality visibility remains UNVERIFIED and is left to GitHub's protected CLEAN merge authority. Live platform health passes.

Actual protected-main disk observations remain pending merge. No reset or allocation clearance is claimed from this diagnostic change. The catalogue prerequisite #5794 is already first in the production queue under the maintainer's approval.

@devantler
devantler marked this pull request as ready for review November 3, 2026 03:21
@devantler
devantler added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit 55c8c37 Nov 3, 2026
51 checks passed
@devantler
devantler deleted the codex/longhorn-block-phase-5782 branch November 3, 2026 03:36
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant