Repository navigation
fix(ci): reject untidy files in every tracked Go module - #5778
Conversation
Part of #5326. Check module boundaries and use read-only tidy diffs before the required Go regression suite. Cover nested modules, sum drift, missing files, workspace redirection and failed discovery with real offline controls. Regenerate existing module drift with Go 1.26.10.
At head The offline fixture reproduces the original gap (ordinary Go tests accept an unused requirement) and passes 12 actual guard controls. These cover root/nested dependency drift, a newly indexed module, sum-only drift, a missing sum, inherited workspace/modfile settings, missing/linked manifests, linked directories, partial failed discovery and empty discovery. Module files are compared before and after each guard invocation. The fixture also passes with inherited ShellCheck, shfmt, actionlint, the policy routing/result-boundary fixture, and the affected Go packages Independent static review found no remaining actionable correctness/security finding after the missing-manifest and proxy-isolation controls were added. Hosted CI, a current-head permitted review, protected merge and post-merge proof remain required; these local receipts are not a claim of delivery. Hosted evidence at prior signed head Current signed head At current head Readiness at exact signed head As a user I exercised the actual nine-module read-only tidy guard and all 12 real module controls, including exact go.mod/go.sum drift assertions; missing and malformed boundaries fail before module work, and failed checks leave source unchanged. This validates the CI guard behavior, not a production change or a portfolio-wide latency improvement. All readable required gates pass. The configured code-quality rule remains unreadable to the helper and is left to the ordinary protected merge service, without an inferred pass. |
@coderabbitai full review |
Action performed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 9 minutes. View limit details
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Linked Issues check |  |
The PR implements the coding requirements in #5326: the repository-local guard checks all tracked modules, rejects discovery and tidy failures, reports the module and go mod tidy, runs before the ex… |
Provide hosted CI evidence on the pull request that the guard passes for the tracked modules and that the required aggregate propagates a guard failure. Then provide the required real-PR proof for the tidy tree. |
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: CI rejects untidy files in every tracked Go module. Description check The description explains why the change is needed and what it does, including checks for all tracked Go modules and read-only failure reporting. Out of Scope Changes check The workflow, guard script, regression controls, validation documentation, contributor guidance, regression-order test, and webapp-compilermodule cleanup all support the requirements in#5326. No u…Full details: Out of Scope Changes check
-
Explanation
The workflow, guard script, regression controls, validation documentation, contributor guidance, regression-order test, and
webapp-compilermodule cleanup all support the requirements in#5326. No unrelated service, credential, cache-writer, or organization-wide workflow change appears in the supplied whole-PR summary.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 3 files. (4 skipped: 4 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Full details: Linked Issues check
-
Explanation
The PR implements the coding requirements in
#5326: the repository-local guard checks all tracked modules, rejects discovery and tidy failures, reports the module andgo mod tidy, runs before the existing Go regression command, and includes offline controls for nested modules, sum-only drift, missing sums, ambient settings, and unchanged module files. The summary also reports propagation through the required aggregate and preservation of the vulnerability fixture. However,#5326requires proof on a real PR. The available evidence states that hosted CI and protected-merge proof remain outstanding, so hosted success and the final tidy-tree proof cannot be established.Resolution
Provide hosted CI evidence on the pull request that the guard passes for the tracked modules and that the required aggregate propagates a guard failure. Then provide the required real-PR proof for the tidy tree.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
@coderabbitai full review |
Action not completed
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
github-project-automation
Bot
moved this from 🚀 Ready to Merge
to ✅ Done
in 🌊 Project Board
Why
Dependency updates can pass Platform CI with inconsistent module files, leaving an unrelated later change to discover the failure.
What
Require consistent dependencies across every tracked Go module before accepting a change, with a clear repair message and no automatic edits. Clean up the existing inconsistencies so the baseline satisfies the new requirement.
Fixes #5326