Repository navigation
fix(publish): approve the v19.0.8 publisher for organization settings - #5741
Conversation
Fixes #5740 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai full review |
Action not completed
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
@codex review for The cluster signer allow-list: confirm only the v19.0.8 commit is added, v19.0.3 stays accepted, and the retired commit is refused. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Static evaluation at
Review: CodeRabbit refused on its limit, and Codex found no major issues at this head. Still owed after deployment: read back that the live |
Why
.github#831moves the organization settings publisher to v19.0.8, and the platform only accepts releases signed by versions it has approved. The approval has to deploy first, otherwise the next settings release is refused in production.What
The platform accepts the v19.0.8 commit (
0966f4b015e85ef14be37411d424a7028a858550) for the.githubconsumer.bd24a3e1) stays accepted, because it signed the current 19.0.8 release.0f390329) is retired, because a consumer accepts at most two canonical commits. The test now refuses it.What changes in the publisher
Nothing that signs or publishes. These files have the same git blob at v19.0.3 and v19.0.8:
.github/workflows/publish-manifests.yamla035ba3d.github/scripts/require-unpublished-version.sh3566e406.github/scripts/recover-manifests-version.sh48dc38f6Authorization ledger
One entry changes, and nothing is added or removed. OCIRepository github-config/github-config moves from
4e833587…731a0to5e2570ec…7406. No artifact URL, RBAC, IAM policy, credential or permission grant changes. I took the new hash from a local render, so the required CI job is what confirms it with the approved tools.Validation
go test ./scripts/validate-eks-ci-role-policypasses.test-publish-workflow-canonical-approvals.shpasses, with v19.0.8 and v19.0.3 accepted, and v10.0.3 and the older commits refused.Not proven yet: deployed acceptance, or a publication by the new signer. After this deploys, read back that the live source still serves the current release, then update
.github#831.Fixes #5740
🤖 Generated with Claude Code