Skip to content

fix(release): use the existing-tag recovery engine - #5523

Merged
devantler merged 1 commit into
mainfrom
codex/recovery-existing-tag-4839-r69
Oct 28, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/recovery-existing-tag-4839-r69

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Older releases remain missing after their tags were created, and the previous recovery attempt was refused during publication.

What

Adopt the released correction that publishes an already verified tag without a separate creation target. Preserve consent, source verification and the release queue; the original incident stays open until real publication and independent no-op checks are complete.

Part of #4839

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at acd697b480c65862512937f246fdd731ef103cff: the independent contract first rejected the old engine pin, then passed the updated workflow and regenerated offline fixture. The shipped read-only capability-refusal controls passed; ShellCheck, actionlint and whitespace checks passed. The four-file diff changes only the immutable source pins, their independent expectation and the operator guide.

The selected v14.0.5 release resolves to signed source 8e2dfbd3f9249b76b58234189ccbbae98d11b32b; all five post-merge workflows passed. Its original repair PR #791 has full native CI and a clean exact-head review.

After this consumer merges, repeat the native safety controls, recover each captured missing publication once, and independently verify the tag/source, latest-release selection and no-additional-write reruns. No retry of the earlier refused request has been sent, and the historical ref-rejection cause remains unproven.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d0e0dec and acd697b.

Files selected for processing: 4
  • .github/workflows/ci.yaml
  • .github/workflows/publish-release-recovery.yaml
  • docs/release-recovery.md
  • scripts/tests/test-release-recovery.sh

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional context used
LanguageTool
docs/release-recovery.md

[uncategorized] ~12-~12: The official name of this software platform is spelled with a capital “H”.
Context: The recovery engine is from [.github v14.0.5](https://github.com/devantler-t...

(GITHUB)

Additional comments: 4
.github/workflows/ci.yaml: 1

776-776: LGTM!

.github/workflows/publish-release-recovery.yaml: 1

90-90: LGTM!

Also applies to: 246-246

docs/release-recovery.md: 1

12-12: LGTM!

scripts/tests/test-release-recovery.sh: 1

24-24: LGTM!

Walkthrough

The release-recovery CI fixture and publishing jobs now use catalogue commit 8e2dfbd3f9249b76b58234189ccbbae98d11b32b. The source guard requires that commit. The documentation updates the recovery engine pin from v14.0.2 to v14.0.5 and adds a description of publishing an admitted existing tag without sending an unused tag-creation target.

Possibly related issues

  • Issue 4839 — The changes adopt the released recovery correction for the tag-present, release-absent case described by this issue.

Possibly related PRs

  • devantler-tech/platform#5477 — This PR updates the recovery workflow, source pin, fixture, guard, and documentation introduced by that PR.

Priority: Normal

Merge Risk: Minimal · up to acd69

The pin update is internally consistent and presents no established merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "fix(release): use the existing-tag recovery engine" matches the main change. The PR updates the release-recovery engine pin to v14.0.5, which publishes an already verified tag without a sep…
Description check Passed The description explains the problem (older releases missing after tags were created, and a refused prior recovery attempt) and the change (adopting the released correction that publishes an already v…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(release): use the existing-tag recovery engine" matches the main change. The PR updates the release-recovery engine pin to v14.0.5, which publishes an already verified tag without a separate creation target. The title is specific and conventional, and it names the release scope. It does not cover the source SHA pin updates, but that is expected.

Full details: Description check

Explanation

The description explains the problem (older releases missing after tags were created, and a refused prior recovery attempt) and the change (adopting the released correction that publishes an already verified tag without a separate creation target). It also notes that consent, source verification, and the release queue are preserved, and links the work to #4839. This relates directly to the changeset, which updates the recovery source pins and the operator guide.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at acd697b480c65862512937f246fdd731ef103cff: complete native CI is green, including the actual pinned-engine build and credential refusal, the default-off contract job and the final required gate. CodeRabbit’s exact-head review is clean; all four changed files were reviewed and there are no unresolved threads or review-body findings. The capitalization hint concerns .github, this repository’s literal name, so its exact spelling is retained.

The newly fetched main changes separate image-verifier and dependency files; it does not overlap this four-file update. Live health is OK. User evaluation includes the source-pin RED/GREEN contract and native execution of the released publisher’s credential refusal. Actual publication and no-op readback remain the protected-main follow-up on #4839/#787 and are not claimed by these offline controls. Queue admission will retain every normal integration/deployment gate.

@devantler
devantler marked this pull request as ready for review October 28, 2026 17:04
@devantler
devantler added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit af57d1b Oct 28, 2026
49 checks passed
@devantler
devantler deleted the codex/recovery-existing-tag-4839-r69 branch October 28, 2026 23:56
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant