Skip to content

feat(ci): validate combined Helm post-render streams - #5505

Merged
devantler merged 2 commits into
mainfrom
codex/kyverno-migration-lifecycle-5491
Oct 28, 2026
Merged

devantler merged 2 commits into
mainfrom
codex/kyverno-migration-lifecycle-5491

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Safe cleanup after upgrades needs deployment checks that examine the migration jobs as well as ordinary application resources.

What

Adds that validation for installation and upgrade, including the exact input Helm gives its renderer. This prepares the migration cleanup for a separate rollout.

Part of #5491

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Validation at d9603f11f4274298469572c3bb9b14dd9675af6f:

  • New controls failed before the change. The complete post-renderer and disruption-budget suites now pass with 114 and 330 assertions, including invalid hook patches, unsupported strategies, and hooks that must never satisfy a workload budget. ShellCheck, workflow lint, and whitespace checks pass.
  • User evaluation used the audited Helm 4.2.4 SDK renderer and the published Kyverno 3.9.2 chart. Capturing the actual input and applying the proposed lifecycle patch changed exactly the expected Job annotation among 80 rendered resources under Kubernetes YAML semantics. No other resource or field changed.
  • The refreshed main branch was merged without changing the tested guard sources. This PR enables validation only; deployment cleanup and its production acceptance remain separate under Clean up successful Kyverno migration jobs after upgrades #5491.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 56 minutes.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7b32a6c and d9603f1.

Files selected for processing: 7
  • .github/workflows/ci.yaml
  • AGENTS.md
  • scripts/guard-helm-post-renderers.sh
  • scripts/guard-pdb-selector-match.sh
  • scripts/prepare-helm-render-input-capture.sh
  • scripts/tests/test-guard-helm-post-renderers.sh
  • scripts/tests/test-guard-pdb-selector-match.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

cr:no-gate@d9603f1 — the included review was refused; the native guard confirms no completed review of this head.

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T10:59:50.030493Z d9603f1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: d9603f11f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready for protected delivery at d9603f11f4274298469572c3bb9b14dd9675af6f: all 49 reported checks are settled without failures, every readable required gate passes, the branch is CLEAN, and there are no review threads or unresolved body findings. Codex's clean receipt 6467233791 binds this head. The real Helm user exercise and its limits are recorded above.

The configured code-quality rule has no readable per-head result, so the completeness helper reports it as UNVERIFIED; the normal protected merge API must decide that rule. This is not a complete-gate claim or an override. #5491 remains open for the separate lifecycle rollout and production acceptance.

@devantler
devantler marked this pull request as ready for review October 28, 2026 11:06
@devantler
devantler added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The merge queue removed this PR for failed_checks at 16:16 UTC. Attempt 40722307528 failed before the application trial: public-image verification hit a GitHub API quota response and correctly refused to exceed its bounded recovery. The production deployment, final queue check and recovery jobs were all skipped.

The existing hosted fixture subsequently passed in job 122943582228, including the real controller and restricted public application step. Source head d9603f1 remains CLEAN, with its current-head Codex pass and no open review findings. No source, check, deadline or credential change is needed for this recovery. Performing one bounded requeue after that verified service recovery.

@devantler
devantler added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 7da5c59 Oct 28, 2026
49 checks passed
@devantler
devantler deleted the codex/kyverno-migration-lifecycle-5491 branch October 28, 2026 22:25
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant