Skip to content

fix(observability): measure endpoint creation queueing safely - #5410

Merged
devantler merged 1 commit into
mainfrom
codex/runtime-latency-metrics-4329
Oct 27, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/runtime-latency-metrics-4329

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The remaining response-time incident needs evidence that separates time spent waiting from time spent processing a request. Existing monitoring does not expose that distinction.

What

Add a manual, read-only measurement that reports timing values and refuses incomplete results. The incident remains open until its cause is corrected and the original objective recovers.

Part of #4329

Part of #4329. Add a dormant reviewed-main diagnostic with finite reads, full agent identity checks, sanitized output and offline failure controls.
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T00:53:55.544113Z 1820faf Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 1820faf1cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 1820faf1cc191bf319c21cc97d43c1aba0a5fa6e: all hosted checks are settled green (38 passed, 9 intentional skips). Codex reviewed this commit without findings; the complete thread and comment reads show no unresolved findings or maintainer requests. The forge reports CLEAN and MERGEABLE. All readable required gates passed; the configured native code-quality rule has no independently readable verdict, so normal forge enforcement remains authoritative.

User evaluation exercised the fixed command against the offline Kubernetes client: five complete sanitized samples succeeded, and missing metrics, read failures, oversized output and replaced agent identities produced INCONCLUSIVE. The workflow guards also rejected an unreviewed ref and an incorrect confirmation. ShellCheck, actionlint and zizmor passed.

Production metric collection requires the reviewed-main workflow under the consumer's pipeline-only read procedure. Its dispatch and the original incident's recovery remain post-merge verification work. The existing retirement has a separately owned live-health failure; this diagnostic remains part of the active response-time investigation, with no platform all-clear claimed.

@devantler
devantler marked this pull request as ready for review October 27, 2026 01:03
@devantler
devantler added this pull request to the merge queue Oct 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 27, 2026
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness refreshed for 1820faf1cc191bf319c21cc97d43c1aba0a5fa6e against freshly fetched main 65e782731c2ff43a77b7fc3812406180f0dc99cd. The head is unchanged and signed, all selected CI checks are settled green, and the current-head Codex clearance remains valid. Complete comments, reviews, inline comments and review-thread reads contain no unresolved finding or maintainer request. GitHub reports CLEAN and MERGEABLE.

All independently readable required checks and workflows pass. The configured code-quality rule remains UNVERIFIED through the read API; normal protected forge enforcement decides it. The current platform health helper passes. This finite diagnostic remains part of the runtime incident response; its reviewed-main execution and the original recovery criteria remain post-merge work. No Coroot or platform all-clear is claimed.

@devantler
devantler added this pull request to the merge queue Oct 27, 2026
Merged via the queue into main with commit 6148403 Oct 27, 2026
48 checks passed
@devantler
devantler deleted the codex/runtime-latency-metrics-4329 branch October 27, 2026 17:10
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant