Repository navigation
feat(staging): prepare the public business ingress hold - #5395
Conversation
At signed head Both schema-aware local and production validations exit 0. Their output explicitly validates the changed hold and Tenant files. Some unrelated Helm expansions are skipped because the host's configured Docker credential helper is absent; those warnings are retained, not reported as complete chart coverage. Hosted CI remains required. The design follows Cilium's documented Gateway ingress identity and deny precedence. These are design evidence, not a measured datapath result. No workload is enabled by this increment. Before any later exposure, #5247 must still verify realized policy/endpoints, protect the Platform-owned hold from tenant changes, validate private-input projection and restricted health, and prove hold → public service → isolation → recovery. Runtime acceptance and portal activation are not claimed here. |
Signed correction The exact test-entry guard reproduced RED before the mode change and passes afterward. Both execute-bit guards and their maintained regression controls pass, as do the rendered staging hold and seven refusal controls. The policy and application flags are unchanged. Fresh hosted CI and substantive exact-head review remain required. |
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Proceeding to the next ordered lane, Codex, without a duplicate CodeRabbit request or paid credits. No green review or promotion is claimed. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at
The current base change updates the maintained KSail pin. Its main workflows succeeded. A peer merge-group is active, and current reads show the protected core layers suspended. Their ownership remains with the deployment pipeline. The health helper exits 0 and the sibling watch is OK. Promotion is separable from that peer deployment; any queue entry and deployment still require fresh checks and the ordinary protected queue. |
Why
Public staging needs a delivery hold in place before its application is enabled, so checks can finish before visitors reach it. Installing the hold separately avoids a brief exposure during the first rollout.
What
Prepare a production-only hold for the business staging service, with boundary checks in CI. Application reconciliation stays disabled; verifying the running service, private input delivery and recovery remains part of the staging rollout.
Part of #5247