Repository navigation
feat(backups): prepare approved Wedding catalogue retirement - #5374
Conversation
Part of #4481. Keep the proof read-only by default; gate exact-object retirement on a recent dedicated restore, current coverage, unchanged source, and unaffected-consumer backup checks.
cr:no-gate@8635471. CodeRabbit's authenticated included-review refusal on this repository remains within its stated recovery window: provider reply. Its event was 13:33 UTC and was re-read immediately before this decision. No current-head review was delivered on this PR; the fresh no-gate guard reports ADMIT. The applicable included-review limit permits progression to the next lane; no paid review, credit reset or duplicate first-lane request is used. All 40 current-head contexts are successful or intentionally skipped, GitHub reports MERGEABLE/CLEAN, and fresh activity, claim and process reads show no active writer. The PR remains draft pending a substantive current-head review. Actual removal and independent post-removal proofs remain after protected merge. |
@codex review for the exact bounded retirement path, preservation of other backups, and refusal before irreversible operations |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at User evaluation: I reran the actual coverage command's regression suite locally (56 cases passed) and inspected the hosted native-client test. The pinned client actually removed the exact stdin-selected disposable file while retaining the neighboring backup; invalid, duplicate and unlisted plans refused before removal, and invalid restore evidence refused workflow admission. This is sufficient evaluation of the dormant dispatch path; it does not claim that production removal has run. The maintainer's approval remains applicable. The merge queue must still validate and deploy this head. Actual retirement, an independent empty-prefix check, fresh unaffected-backup receipts and final documentation evidence remain outstanding under #4481. |
Why
The retired Wedding backup copy remains readable through shared backup access after the live database moved to its dedicated storage.
What
Adds the approved, explicitly confirmed retirement with fresh safety proofs and checks that the other shared backups still work. Actual removal and its final evidence follow protected merge.
Part of #4481