Skip to content

fix(deps): keep go-github on the major ghinstallation uses - #5325

Merged
devantler merged 1 commit into
mainfrom
claude/go-github-major-hold
Oct 25, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/go-github-major-hold

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The alert publisher uses two libraries that must agree on the GitHub client's major version, and the sign-in library still uses the older one. Automated upgrades to the newer major therefore cannot build: one already merged as an unused leftover, and a second is now red.

What

Removes the unused leftover and makes major upgrades of the GitHub client wait on the dependency bot's dashboard for approval, to be taken together with a sign-in library release on the same major. Minor and patch updates still arrive as before, and this replaces #5321.

No issue: trivial fix.

The go-github v93 requirement merged in #5314 is unused: the alert
publisher still imports v88, which ghinstallation/v2 requires for its
token options. Tidy it away and hold go-github majors for Dependency
Dashboard approval so a go.mod-only major bump is not proposed again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 44 minutes.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 44 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between fb66063 and 7b7cad6.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 2
  • .github/renovate.json
  • go.mod
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T08:27:02.637355Z 7b7cad6 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 7b7cad6881

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 7b7cad68: CI green (37 pass, 11 skipped), Codex review clean at this head, 0 unresolved threads, merge state CLEAN. The diff only removes the unused go-github v93 require (go mod tidy) and holds go-github majors for Dependency Dashboard approval until ghinstallation adopts one. Promoting and queuing pinned to this head.

@devantler
devantler marked this pull request as ready for review October 25, 2026 09:04
@devantler
devantler added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit f4728c1 Oct 25, 2026
48 checks passed
@devantler
devantler deleted the claude/go-github-major-hold branch October 25, 2026 10:22
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant