Repository navigation
chore(backstage): retire the completed retirement fence and tooling - #5161
Conversation
The stateless Backstage retirement completed on 18 October and its completion step removed the namespace journal. Every rule of the restrict-backstage-retirement ClusterPolicy is gated on that journal, so the policy, its 18 Kyverno test fixtures and the one-shot assess, retire, check and complete workflows (with their scripts and the poller-native test module) can no longer act. Remove them, and the deploy-path terminal-state handoff that only that completion used. The retained database, its storage protection workflow and internal/portalstorage are unchanged (#5122). The checksum-verified Helm install that later CI steps consume is kept as its own step. Fixes #5159 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai full review |
|
@codex review for This removes a finished retirement fence and its tooling. Check that nothing still running (deploy path, CI aggregate, merge-group heal, retained-storage protection) depended on a removed file, step or output. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ready at
After deployment I will confirm the policy is gone and the database and claims are unchanged. |
Why
The Backstage portal retirement finished on 18 October, and the safety fence and one-time workflows built for it only act while a retirement is in progress, so they now protect nothing. They would otherwise have to be rewritten at real cost before the planned policy-engine upgrade. Their test-only code also carries all 21 open security alerts on this repository.
What
Removes the finished retirement fence, its tests and the one-time retirement workflows and tooling, and updates the docs to say the retirement is complete. The kept portal database and the protection on its storage are unchanged. Whether to keep that data is still a separate decision.
Fixes #5159
👉 After merge/promotion: check in production that the old fence is gone and the kept database is unchanged.