Repository navigation
ci: run complete Flux bridge validation alongside manifest checks - #5076
Conversation
Local verification at
The workflow combines cleanly with the queued policy split and the complete-Go integration in read-only merge-tree checks. The current hosted run is 39169088324; its outcome, a substantive current-head review and protected merge acceptance are still pending. This is not a delivered performance claim; the parent retains its multi-run post-merge measurement criteria. |
Current head The existing 31-case Bash suite reproduced the failure locally. A further negative control exposed a related blind spot: an unrelated action carrying a similarly named input could mask a missing result on the real aggregate. The test now locates and checks the actual aggregate action by identity. All original cases plus that additional control pass: 32/32 on Bash 5 and macOS Bash 3.2. The complete root Go suite, ShellCheck and diff checks also pass on the corrected source. No family, assertion, production dependency or timeout was removed or weakened. The earlier Bash pass preceded the final aggregate-order adjustment; it was not sufficient verification of that adjustment. This correction reruns the affected suite on the final source rather than carrying that earlier observation forward. The workflow itself is unchanged from the earlier local Go-boundary proof, and a new hosted run plus substantive current-head review are still required. This remains a draft. Result evidence is scoped to the actual aggregate actions before checking their inputs. The final source combines cleanly with the integrated guard candidate |
@coderabbitai full review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at
Creation-to-required feedback for this standalone candidate was 48m29s and summed occupied non-skipped runner time 70m57s. These are one pre-merge observation, not the combined improvement, billed cost or the three post-delivery measurements required by #4569. All genuine pre-promotion conditions hold; the next step is ordinary protected merge-queue acceptance, not an admin/auto-merge bypass. Delivery remains outstanding until the source head actually merges. |
Why
Platform checks wait for a long offline test family before completing manifest validation. That family takes about six and a half minutes in the recorded baseline, extending feedback for changes that require both.
What
Run the complete offline family alongside manifest checks without removing tests or changing which changes are checked. Deployment rules remain unchanged, and incomplete selected checks still block merging.
Fixes #5075