Repository navigation
fix(deps): move the Go module to Go 1.26.9 and golang.org/x/net 0.60.0 - #4963
Conversation
The root module's deploy and CI tooling was built on Go 1.26.6 and golang.org/x/net 0.58.0, which carry the GO-2026-6603..6617 advisories. Every workflow that builds this module installs Go from go.mod, so the directive bump moves CI and deploy tooling to the fixed toolchain. golang.org/x/sys and golang.org/x/text follow x/net's minimums. Fixes #4684 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Validation at head
|
|
|
@cursor review |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 97842eca-2c10-48d2-9f33-1ac73db64b89) |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer (interactive Claude Code session)
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: aae32980e13d3a3fab0cd48f47901ae83b2df935
- CodeRabbit: rate limited. Its summary on #4964 (20:57 UTC) states the plan's included review allowance is 1 per hour with 0 remaining.
- Codex: usage limit reached. Codex answered the request on #4964 (20:56 UTC) with its usage-limit reply and a failed review.
- Cursor Bugbot: usage limit reached — requested on this PR at this head, its check-run ended
neutral/Errorwith "Bugbot couldn't run - usage limit reached" (21:15 UTC).
Scope reviewed: go.mod and go.sum only.
- The
godirective becomes 1.26.9, the newest 1.26 patch release on go.dev, and every workflow that builds this module reads it throughgo-version-file: go.mod. The only workflow that pins its own Go builds an upstream hotfix image, not this module. golang.org/x/netbecomes 0.60.0, andx/sys0.48.0 andx/text0.42.0 are its minimums.go.sumswaps exactly those pairs, plus thex/tools0.49.0 checksum that x/net's module graph names. No otherrequirechanges, and nothing is added or removed beyond that.- A version scan of the module goes from 18 known advisories to 0. The build, vet and the full test suite pass with the exact toolchain, and CI's Go helper suite and every validator pass at this head.
- No behaviour or interface change is intended. Nothing in the diff touches a workflow, a permission, a secret or a manifest.
Verdict: no P0/P1 findings
Readiness at head
Promoting and queueing at this head. |
Why
The platform's deployment and CI tools are built with a Go release and a networking library that have known security advisories. Fixed releases of both are available, and two sibling repositories already moved to them.
What
Build the platform's own tools with the fixed Go release and the fixed networking library. Tool behaviour does not change. The separately pinned rendering tool keeps its audited build on purpose.
🤖 Generated with Claude Code
Fixes #4684