Repository navigation
fix(kyverno): preserve severity in every controller log - #4920
Conversation
Use the shared structured formatter without changing verbosity or other controller arguments. Extend the native chart and Coroot CRI regression to the remaining producers and informational Alert deprecation notices, preserving genuine critical reporting. Part of #4919
The immutable node-agent image is built from ee62018e73b90b1549f5b81ba0d3d6e28851a1df, whose logparser dependency is v1.4.0. Match that consumer in this test-only import instead of treating a newer library as deployment proof. No runtime agent or other dependency changes.
The pinned native renderer reports one changed HelmRelease and no membership changes. Record the native all-controller formatter comparison and preserved authorization boundaries alongside the exact ledger delta.
Validation at signed
User evaluation exercised the real chart boundary and CRI parser with the observed message shape, not a substitute parser. Fresh OIDC readback confirms admission already uses JSON while the other three deployed controller types use text; all eight controller pods are Ready. Correctness, simplicity and security self-review found no additional issue: use the existing shared formatter, retain all original severity controls, and change no authority or production credentials. Hosted current-head CI 38754654939 and substantive exact-head review remain required before promotion/merge. Actual rollout and separated producer/Coroot acceptance remain open under #4919; neither historical log entries nor thresholds were changed. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ready at signed Codex's completed exact-head review reports no major issues; the full conversation, review objects and thread census contain no outstanding finding. All four source commits have valid signatures and the branch is mergeable. The native chart and actual CRI-consumer evaluation, RED/GREEN proof and validation limits are recorded in the earlier validation comment. The change retains informational notices and genuine warning/error/fatal levels; it does not silence messages or weaken checks. This is ready for the ordinary merge queue, not evidence of rollout or alert clearance. #4919 stays open for deployment readback and separated live producer/Coroot samples. |
Why
Kyverno's reports controller is still producing misleading fatal events in Coroot. The earlier logging repair covered admission only, leaving the other controllers exposed to the same severity misclassification.
What
Use structured logging across every controller while preserving verbosity, complete notices and genuine warning, error and fatal reporting. Extend the existing regression to cover all producers and the observed deprecation-notice failure, using the deployed consumer version.
Part of #4919