Repository navigation
fix(homepage): remove the two legacy site headings - #4770
Conversation
Tenant routes now use the Clients and Personal groups, so the Customer Sites and Personal Sites headings and their admission aliases have no users left. Drop them from the Homepage layout and from the allow-list, and prove with policy tests that the retired names are denied while the current site groups are accepted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
CodeRabbit is rate limited for this head, so the review moves to the next lane. @codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The production blocker has cleared: #4775 merged as At unchanged head I evaluated the actual head's policy with Kyverno: all 14 fixtures passed, including acceptance of Clients and Personal and rejection of both retired groups. I also parsed the embedded Homepage settings and verified that the current groups remain declared while the retired headings are absent. This is an offline evaluation; deployed presentation will be checked after the protected rollout. Resume the normal protected queue at this exact head. Queue admission remains separate from merge and production convergence. |
Removed from the merge queue at 02:23 UTC; cause found, not this change. Re-queued at the same head (
|
Why
The dashboard was reorganised into Business, Clients and Personal site groups. While the two tenant sites moved over, the old "Customer Sites" and "Personal Sites" headings were kept so nothing disappeared mid-rollout. Both sites now use the new groups in production, so the old headings are empty leftovers and the rule that guards group names still accepts two names nobody should use any more.
What
The two old headings are removed from the dashboard, and a site that asks for one of them is now refused the same way as any other unknown group. Checks prove that the current groups are accepted and the retired names are refused.
Fixes #4711