Skip to content

fix(homepage): remove the two legacy site headings - #4770

Merged
devantler merged 1 commit into
mainfrom
claude/homepage-remove-legacy-site-groups-4711
Oct 12, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/homepage-remove-legacy-site-groups-4711

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The dashboard was reorganised into Business, Clients and Personal site groups. While the two tenant sites moved over, the old "Customer Sites" and "Personal Sites" headings were kept so nothing disappeared mid-rollout. Both sites now use the new groups in production, so the old headings are empty leftovers and the rule that guards group names still accepts two names nobody should use any more.

What

The two old headings are removed from the dashboard, and a site that asks for one of them is now refused the same way as any other unknown group. Checks prove that the current groups are accepted and the retired names are refused.

Fixes #4711

Tenant routes now use the Clients and Personal groups, so the Customer
Sites and Personal Sites headings and their admission aliases have no
users left. Drop them from the Homepage layout and from the allow-list,
and prove with policy tests that the retired names are denied while the
current site groups are accepted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ff4dc5f8-74d9-437d-a3ee-871c3eaac9a9

📥 Commits

Reviewing files that changed from the base of the PR and between 0d19424 and 7905a02.


📒 Files selected for processing (4)
  • k8s/bases/apps/homepage/config-map.yaml
  • k8s/bases/infrastructure/cluster-policies/best-practices/restrict-homepage-service-groups.yaml
  • tests/restrict-homepage-service-groups/kyverno-test.yaml
  • tests/restrict-homepage-service-groups/resources.yaml

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

CodeRabbit is rate limited for this head, so the review moves to the next lane.

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T21:20:30.673868Z 7905a02 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 7905a02c85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review October 11, 2026 21:55
@devantler
devantler added this pull request to the merge queue Oct 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 11, 2026
@devantler

devantler commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocker cleared 2026-10-12: #4775 merged at 00:48 UTC and a production deploy from the merge queue passed at 01:19 UTC (run 38189664833, for #4778). The blocked label is removed and this pull request is released to merge again.

@devantler devantler removed the blocked label Oct 12, 2026
@devantler
devantler added this pull request to the merge queue Oct 12, 2026
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The production blocker has cleared: #4775 merged as 800504997bf9c01e4a26aadf76c7e6e1f0859be8, and its protected deployment 38187878684 passed maintenance preparation, publication and reconciliation. I read the failed deployment 38180721118 and confirmed the same interrupted-maintenance guard caused its eviction.

At unchanged head 7905a02c8590871e2e11c74980e1e42f0f99f9d6, CI 38175768333 passed and Codex's authenticated clean verdict names this head. Complete comment, review, inline and thread reads show no findings or maintainer requirements. Readable required checks and workflows pass; the configured code-quality analysis remains unexposed and is not reported as a pass. GitHub reports this head CLEAN.

I evaluated the actual head's policy with Kyverno: all 14 fixtures passed, including acceptance of Clients and Personal and rejection of both retired groups. I also parsed the embedded Homepage settings and verified that the current groups remain declared while the retired headings are absent. This is an offline evaluation; deployed presentation will be checked after the protected rollout.

Resume the normal protected queue at this exact head. Queue admission remains separate from merge and production convergence.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 12, 2026
@devantler

devantler commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Removed from the merge queue at 02:23 UTC; cause found, not this change. Re-queued at the same head (7905a02c).

  • What failed: the production deploy in run 38194496846 stopped before publishing, at the storage-maintenance step, with Longhorn client maintenance HOLD: backing volume inventory changed. Nothing was published, and the recovery job restored main.
  • Why: that step compares the number of storage volumes with the number recorded by the last maintenance (16). It ran at 02:22 UTC, four minutes into the nightly full backup (02:17–02:39 UTC), which creates short-lived volumes while it copies data. The step ran clean in the deploy before this one (01:58 UTC), and read back after the backup ended the live count is 16 again and matches the record.
  • Now: production is healthy, the backup has ended, and the next queue entry started its deploy after that. The lasting fix (a deploy must not fail only because the nightly backup is running) is tracked in fix(deploy): a production deploy fails at its storage check whenever the nightly backup is copying a volume #4784.

@devantler
devantler added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit 4c846da Oct 12, 2026
33 checks passed
@devantler
devantler deleted the claude/homepage-remove-legacy-site-groups-4711 branch October 12, 2026 05:53
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Separate business, client and personal sites on Homepage

1 participant