Repository navigation
fix(arc): report transport trial failures accurately - #4762
Conversation
At The correctness, simplification and security pass keeps cleanup, admission, transport and identity checks unchanged. Readback and parsing are separated so parsing cannot mask an API failure. The source of the original native failure remains unknown; #4570 stays open and no runner activation or credential access is authorized by these fixtures. |
@coderabbitai full review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cr:no-gate@91b7f7d — the current-head CodeRabbit request was rate-limited, not reviewed. Fresh provider evidence: #4762 (comment), event 2026-10-11T18:55:39Z, observed at 18:56Z. The repository-scoped included OSS limit reports 31 minutes until recovery (19:26:39Z). No usage-based review is being enabled. Continuing to the next review lane; this refusal is not a verdict. |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at 91b7f7d: native CI passed, the exact-head Codex review found no major issues (#4762 (comment)), and fresh thread/body reads contain no unresolved findings. The head is signed, mergeable and CLEAN; the PR body follows the effective template. The unreadable code-quality analysis is not being represented as a passed local observation; GitHub reports CLEAN. User evaluation exercised the actual Bash orchestration with injected command failures: all 48 cases passed, preserving original exit codes, static failure phases, private-error suppression and UID-bound cleanup. An independent current-head review reproduced those cases without findings. This proves diagnostic behavior, not native transport acceptance. The protected native trial remains a separate requirement under #4570, with runner activation and credential access still gated. |
Why
A failed runner transport trial can report the wrong cause, preventing targeted repairs and delaying safe activation.
What
Report the failed verification step and retain its original failure status, while keeping private diagnostics suppressed and cleanup checks intact. Transport acceptance and runner activation still require successful protected verification.
Fixes #4761
Part of #4570