Skip to content

fix(arc): report transport trial failures accurately - #4762

Merged
devantler merged 1 commit into
mainfrom
codex/native-arc-verification-4570-01a12c1e
Oct 11, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/native-arc-verification-4570-01a12c1e

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

A failed runner transport trial can report the wrong cause, preventing targeted repairs and delaying safe activation.

What

Report the failed verification step and retain its original failure status, while keeping private diagnostics suppressed and cleanup checks intact. Transport acceptance and runner activation still require successful protected verification.

Fixes #4761
Part of #4570

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

At 91b7f7d49d2c41dec181900697735fb1b713b34d, the stale-phase regression is RED before the repair and all 48 orchestration cases are GREEN afterward. The failed-command cases verify original exit codes, fixed phases, private-error suppression and owned probe/tunnel cleanup. Parser race tests, inactive-runner boundary tests, shell checks and the Bash initialization guard pass.

The correctness, simplification and security pass keeps cleanup, admission, transport and identity checks unchanged. Readback and parsing are separated so parsing cannot mask an API failure. The source of the original native failure remains unknown; #4570 stays open and no runner activation or credential access is authorized by these fixtures.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 31 minutes.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 48eaae33-cb3a-4fec-8f9c-c30765e33c70

📥 Commits

Reviewing files that changed from the base of the PR and between 8be116d and 91b7f7d.


📒 Files selected for processing (2)
  • scripts/tests/test-verify-arc-transport.sh
  • scripts/verify-arc-transport.sh

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

devantler commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

cr:no-gate@91b7f7d — the current-head CodeRabbit request was rate-limited, not reviewed. Fresh provider evidence: #4762 (comment), event 2026-10-11T18:55:39Z, observed at 18:56Z. The repository-scoped included OSS limit reports 31 minutes until recovery (19:26:39Z). No usage-based review is being enabled. Continuing to the next review lane; this refusal is not a verdict.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T18:58:18.240668Z 91b7f7d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 91b7f7d49d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 91b7f7d: native CI passed, the exact-head Codex review found no major issues (#4762 (comment)), and fresh thread/body reads contain no unresolved findings. The head is signed, mergeable and CLEAN; the PR body follows the effective template. The unreadable code-quality analysis is not being represented as a passed local observation; GitHub reports CLEAN.

User evaluation exercised the actual Bash orchestration with injected command failures: all 48 cases passed, preserving original exit codes, static failure phases, private-error suppression and UID-bound cleanup. An independent current-head review reproduced those cases without findings. This proves diagnostic behavior, not native transport acceptance. The protected native trial remains a separate requirement under #4570, with runner activation and credential access still gated.

@devantler
devantler marked this pull request as ready for review October 11, 2026 19:13
@devantler
devantler added this pull request to the merge queue Oct 11, 2026
Merged via the queue into main with commit 099eec9 Oct 11, 2026
32 checks passed
@devantler
devantler deleted the codex/native-arc-verification-4570-01a12c1e branch October 11, 2026 19:25
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Identify the failing ARC transport operation accurately

1 participant