Skip to content

fix(dr): show all storage disks and credential reboot requirements - #4461

Merged
devantler merged 1 commit into
mainfrom
codex/dr-all-disks-3191-round14
Oct 4, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/dr-all-disks-3191-round14

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Recovery guidance can hide an unhealthy storage disk and leave operators unsure when a changed pull credential needs a reboot. Either gap can turn routine recovery into an outage.

What

Report every storage disk before node removal and identify missing status clearly. Explain the required drain and reboot for changed credentials while preserving the lighter path for an image update. Also addresses #4084.

Fixes #3191

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 31 minutes.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b0abf36f-3704-49b4-a53d-0b907e12485a
📥 Commits

Reviewing files that changed from the base of the PR and between 4c4684c and d3e4cbc.

📒 Files selected for processing (3)
  • .github/workflows/ci.yaml
  • docs/dr/runbook.md
  • scripts/tests/test-dr-longhorn-disk-preflight.sh
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler devantler left a comment •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: d3e4cbc

  • CodeRabbit: exact-head request explicitly refused as rate limited at 2026-10-04T09:39:03Z on this PR; recovery is the included allowance reset.
  • Codex: authenticated account usage-limit refusal at 2026-10-04T02:11:02Z on ksail#7433 (issuecomment-5975665569), freshly re-read; recovery requires an account change by the maintainer.
  • Cursor Bugbot: authenticated team usage-limit refusal at 2026-10-03T22:35:03Z on platform#4438 (issuecomment-5974201634), freshly re-read; recovery requires a user/team admin change.

Reviewed the complete diff, actual runbook-query extraction, per-disk capacity and scheduling behavior, unknown/zero handling, and CI wiring. The regression executes the runbook's filter; the read-only production comparison preserves availability and scheduling values while adding disk labels. The credential text matches the existing credential-change reboot path and distinguishes it from image-only refresh. Direct current-head review objects, conversations, threads and Bugbot check-runs contain no outstanding finding.

Verdict: no P0/P1 findings

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at d3e4cbcdeef7ae89746382968d141ff8929804b8: all required and repository-owned checks passed, including CI run 37190315886. The exact-head local review passes the canonical verdict helper; all three external provider limits were verified from authenticated artifacts. No unresolved threads, non-thread findings or base conflict remain.

User evaluation: Executed the actual runbook query against synthetic multi-disk, single-disk, zero/missing-capacity and empty-disk-status inputs. Its read-only production comparison preserved existing capacity/scheduling values and added disk labels. The credential correction is documentation of the existing reboot path; it has no additional runtime surface to exercise.

Promoting this tested and reviewed delivery, then driving its normal merge-queue deployment.

@devantler
devantler marked this pull request as ready for review October 4, 2026 09:51
@devantler
devantler added this pull request to the merge queue Oct 4, 2026
Merged via the queue into main with commit 028747a Oct 4, 2026
34 checks passed
@devantler
devantler deleted the codex/dr-all-disks-3191-round14 branch October 4, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

docs(dr): stranded-node pre-flight reads only the first Longhorn disk

1 participant