Skip to content

fix(ci): fail the SSO redirect guard when a layer does not build - #4359

Merged
devantler merged 1 commit into
mainfrom
claude/platform-sso-guard-build-status-4357
Oct 2, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/platform-sso-guard-build-status-4357

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

The check that protects single sign-on could pass without reading part of the platform. When one section of the configuration failed to build, the check treated it as empty and reported a misleading problem, or none at all.

What

The check now stops as soon as a section fails to build and names that section and the build error. A deliberately broken section now produces that build error instead of an unrelated complaint about login addresses.

Fixes #4357

Fixes #4357

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 49 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b9ccf35f-27c5-4c27-b3d0-745ee221af66

📥 Commits

Reviewing files that changed from the base of the PR and between 3b1676d and feeeed4.

📒 Files selected for processing (1)
  • scripts/tests/test-oauth2-proxy-sso-redirects.sh
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: feeeed4d1030efa8f9730b00f5142a96b4e3941f

  • CodeRabbit: refused the 14:13Z request at this head with "Review rate limited" (14:13:59Z); next review stated ~49 min later.
  • Codex: usage limit since 2026-10-01T01:05Z (maintainer-only reset).
  • Cursor Bugbot: no evidence of a working check-run on this repository (lane health NO-EVIDENCE).

Checked: the build's own status now gates fail (the group's status was printf's, and set -e is suspended on the left of ||); the separator still lands between layers; set -euo pipefail aborts on a failed separator write; the other command substitutions in the script carry their status through pipefail; no other { …; } >> … || group exists under scripts/ or .github/. Ablation: a deliberately broken hetzner/apps layer now fails naming the layer and the kustomize error; the pre-fix script failed on an unrelated Dex-callback symptom. Real run: PASS over 12 hosts. shellcheck clean.

Verdict: no P0/P1 findings

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at feeeed4d. CI green (23 passed, 9 skipped), 0 review threads, local review GREEN self@feeeed4d (all three review lanes unavailable). Evaluated by breaking one layer on purpose: the guard now fails naming that layer and its build error, where it previously reported an unrelated Dex-callback problem. Promoting and enqueueing.

@devantler
devantler marked this pull request as ready for review October 2, 2026 14:31
@devantler
devantler added this pull request to the merge queue Oct 2, 2026
Merged via the queue into main with commit 84b87e0 Oct 2, 2026
32 checks passed
@devantler
devantler deleted the claude/platform-sso-guard-build-status-4357 branch October 2, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

SSO redirect guard reads a layer that failed to build as an empty one

1 participant