Repository navigation
fix(ci): fail the SSO redirect guard when a layer does not build - #4359
Conversation
Fixes #4357 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 49 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
devantler
left a comment
There was a problem hiding this comment.
🤖 Generated by the Agentic Engineer
Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)
Reviewed commit: feeeed4d1030efa8f9730b00f5142a96b4e3941f
- CodeRabbit: refused the 14:13Z request at this head with "Review rate limited" (14:13:59Z); next review stated ~49 min later.
- Codex: usage limit since 2026-10-01T01:05Z (maintainer-only reset).
- Cursor Bugbot: no evidence of a working check-run on this repository (lane health NO-EVIDENCE).
Checked: the build's own status now gates fail (the group's status was printf's, and set -e is suspended on the left of ||); the separator still lands between layers; set -euo pipefail aborts on a failed separator write; the other command substitutions in the script carry their status through pipefail; no other { …; } >> … || group exists under scripts/ or .github/. Ablation: a deliberately broken hetzner/apps layer now fails naming the layer and the kustomize error; the pre-fix script failed on an unrelated Dex-callback symptom. Real run: PASS over 12 hosts. shellcheck clean.
Verdict: no P0/P1 findings
Readiness at |
Why
The check that protects single sign-on could pass without reading part of the platform. When one section of the configuration failed to build, the check treated it as empty and reported a misleading problem, or none at all.
What
The check now stops as soon as a section fails to build and names that section and the build error. A deliberately broken section now produces that build error instead of an unrelated complaint about login addresses.
Fixes #4357