Skip to content

chore(deps): update dependency alex1989hu/kubelet-serving-cert-approver to v0.12.1 - #4114

Merged
devantler merged 3 commits into
mainfrom
renovate/alex1989hu-kubelet-serving-cert-approver-0.x
Sep 24, 2026
Merged

devantler merged 3 commits into
mainfrom
renovate/alex1989hu-kubelet-serving-cert-approver-0.x

Conversation

@renovate

@renovate renovate Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Update Change
alex1989hu/kubelet-serving-cert-approver patch 0.12.0 → 0.12.1

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

alex1989hu/kubelet-serving-cert-approver (alex1989hu/kubelet-serving-cert-approver)

v0.12.1

Compare Source

Chore
  • bump docker/setup-qemu-action from 4.2.0 to 4.3.0
  • bump helm/kind-action from 1.14.0 to 1.15.0
  • bump github/codeql-action from 4.37.8 to 4.37.9
Ci
  • authenticate against guide
  • update nancy ignore
Fix
  • add startup probe for slow API server handshakes at start-up

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@botantler-1
botantler-1 Bot enabled auto-merge September 23, 2026 19:44
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why this is red, and why it is not self-finishing. Renovate moved only cert_approver_version to 0.12.1. The vendored manifest, its pinned source commit and SHA-256, and the image digest the kustomization pins are still the 0.12.0 values, so guard-cert-approver-image-pin fails (newTag is '0.12.0', but the updater's version is '0.12.1'). That is the intended behaviour: the repository's Renovate rule requires a reviewed whole-bundle refresh for this dependency.

The refresh has to read the upstream project's release content, which an unattended run does not do outside devantler-tech. This stays open as the new-release signal until someone runs scripts/update-vendored-operators.sh for v0.12.1 and commits the refreshed bundle here.

@devantler
devantler disabled auto-merge September 23, 2026 23:00
@devantler
devantler marked this pull request as draft September 23, 2026 23:00
Renovate bumped only cert_approver_version, so the image-pin guard failed.
Move the source commit, manifest SHA-256 and image digest to v0.12.1 and
re-vendor the deployment (adds upstream's startupProbe). Commit and bytes
resolved via the Go module proxy; digest via ghcr.io.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

This bump could not finish on its own: Renovate moved only the version, so the image-pin guard failed on the stale tag. I pushed one adaptation commit that moves the source commit, manifest checksum and image digest to 0.12.1 and re-vendors the deployment. The only upstream change is a new startup probe.

  • Commit and manifest bytes come from the Go module proxy. As a control, 0.12.0 from the proxy reproduces the existing pinned commit and checksum exactly.
  • The image digest comes from the registry. The 0.12.0 control matches the existing pin.
  • Locally, update-vendored-operators.sh --validate-committed and the guard's test (18/18) pass, the render pins 0.12.1@sha256:445a8e55…, and Checkov reports 0 failed checks on the new deployment.

I converted the PR to draft and turned auto-merge off. Because the head now carries an agent commit, it needs a normal review before it is promoted again.

@renovate

renovate Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

@coderabbitai review

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T23:46:51.915653Z a0c52df Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: a0c52df6e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Readiness at a0c52df6e18b0b5fb34759eb8abd082d6cbd9639

  1. Tested. All required checks are green at this head, including the vendored-operator validation that was failing before. Locally, update-vendored-operators.sh --validate-committed passes, the annotator tests pass (47/47), and the image-pin guard test passes (18/18).
  2. Reviewed. Codex reported no major issues at this head, with 0 unresolved threads. CodeRabbit never responded to its request here (recorded as no-gate).
  3. Tried as a user. Rendering the controller layer's kustomization pins the operator to ghcr.io/alex1989hu/kubelet-serving-cert-approver:0.12.1@sha256:445a8e55…. The only upstream change is a startup probe on /healthz, and Checkov reports 0 failed checks on the new deployment. Production is confirmed read-only after the merge-queue deploy.

Promoting and enqueuing at this head.

@devantler
devantler marked this pull request as ready for review September 23, 2026 23:47
@devantler
devantler added this pull request to the merge queue Sep 23, 2026
Merged via the queue into main with commit 55b1674 Sep 24, 2026
30 checks passed
@devantler
devantler deleted the renovate/alex1989hu-kubelet-serving-cert-approver-0.x branch September 24, 2026 00:05
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant