Skip to content

fix(ci): retry brief download failures when installing supply-chain tools - #4024

Merged
devantler merged 1 commit into
mainfrom
claude/supply-chain-download-retry-4023
Sep 21, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/supply-chain-download-retry-4023

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Every platform change is checked by a job that downloads two signing and inventory tools from GitHub. When GitHub briefly answers with a server error, as it did repeatedly this afternoon, the job fails outright and blocks unrelated changes; the production deploy installs the same tools and would fail the same way.

What

The downloads now retry a few times before giving up. The downloaded tools are still checked against the exact versions we reviewed, and a download that keeps failing still stops the job.

Fixes #4023

…ools

Both pinned tool downloads ran once, so a momentary 5xx from GitHub's
release host failed manifest validation on every PR and would fail the
merge-queue deploy that installs the same tools. Retry curl's transient
failures a few times; the digest check against the reviewed pin and the
fail-closed behaviour on a persistent failure are unchanged.

Fixes #4023

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Tried as a user. Ran the exact new download command (same flags, including --retry 5 --retry-delay 3) with the real curl against the pinned syft 1.51.1 release asset: exit 0, and the bytes match the reviewed SHA-256 pin. The retry path itself is curl's own behaviour on timeouts, 408, 429 and 5xx, so it is asserted rather than reproduced: the installer test now fails on main (download does not retry transient failures) and passes here, and its existing checks still prove a persistent download failure is refused with nothing installed.

Evidence for the fix: the failing step on #4020 and #4022 (and #4022's re-run) was curl: (22) The requested URL returned error: 504 in this installer.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

@devantler: I will perform a full review of #4024.

⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 33 minutes.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5fec6727-d059-4015-895a-60e6deacf4c5

📥 Commits

Reviewing files that changed from the base of the PR and between 398297c and f92770f.

📒 Files selected for processing (2)
  • .github/scripts/setup-supply-chain-tools.sh
  • scripts/tests/test-setup-supply-chain-tools.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

CodeRabbit refused this head (rate limited) and Codex is at its usage limit, so this round advances to Bugbot.

@devantler

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit f92770f. Configure here.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at f92770f: all checks green, including 🧪 Validate Manifests running the changed installer; Cursor Bugbot green at this head with no findings (CodeRabbit refused this round on its hourly limit, Codex at its usage limit); 0 threads; tried as a user per the comment above. Promoting and adding to the merge queue.

@devantler
devantler marked this pull request as ready for review September 21, 2026 15:54
@devantler
devantler added this pull request to the merge queue Sep 21, 2026
Merged via the queue into main with commit 9132ed5 Sep 21, 2026
31 checks passed
@devantler
devantler deleted the claude/supply-chain-download-retry-4023 branch September 21, 2026 16:19
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Retry transient release-download failures when installing supply-chain tools

1 participant