Repository navigation
fix(observability): complete OpenCost production retirement - #3822
Conversation
Add a default-off manual main deployment path that safely deletes the prune-protected OpenCost HelmRelease and namespace after Flux convergence, then verifies the orphan detector is clean. Include behavioral and wiring regressions for ordering, ownership, PVC, and merge-group safety.\n\nRefs #3810
Reuse the existing required Coroot convergence entrypoint for the OpenCost retirement behavior and wiring tests, avoiding overlap with other active owners of the shared CI workflow.\n\nRefs #3810
@coderabbitai review |
|
|
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review for the fail-closed OpenCost retirement path, GitHub Actions activation boundary, deletion ordering, and independent runtime verification |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ade8750579
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Refuse stale manual dispatches before publication and execution, and register every retirement safety file in the authoritative k8s change filter.\n\nRefs #3810
@codex review for the resolved CI path-selection and stale-main dispatch findings, plus the complete fail-closed retirement flow |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a5692c4d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@codex review for verify the Flux inventory fail-closed fix and the complete production-retirement safety path |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness evidence
Ready for the merge queue. |
Why
PR #3818 removed OpenCost from the desired manifests, but production correctly retained its prune-protected release and namespace. OpenCost is therefore still running and the convergence is incomplete.
What
Add a default-off, protected production action that safely removes only the orphaned OpenCost installation and independently verifies it is gone. Merge-group and recovery deploys cannot activate the deletion.
Operational gate: after this merges, dispatch CD from
mainwithretire-opencostenabled; then remove the one-shot tooling.Part of #3810