Skip to content

fix(wedding-db): correct pre-loss recovery witness - #3742

Merged
devantler merged 1 commit into
mainfrom
codex/wedding-db-recovery-witness-fix
Sep 12, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/wedding-db-recovery-witness-fix

Conversation

@devantler

Copy link
Copy Markdown
Contributor

The first Wedding database recovery run refused before its first database command because the pinned Flux reconciliation digest had one mistyped hex character. The live history records ba344a9c; the recovery guard expected ba344e9c.

This corrects the exact pre-loss witness, covers it with a regression test, and reports only an allow-listed phase name when a trusted recovery run refuses. Untrusted invocations still receive the generic message and no subprocess details.

Validation:

  • node --test tests/wedding-db-incident-recovery/recovery.test.mjs
  • git diff --check
  • Read-only production replay of every source guard; all guards passed and a wrapper blocked the first intended mutation at SELECT pg_switch_wal()
  • Live witness re-read from the Wedding Flux Kustomization: 2026-09-09T01:57:41Z, successful reconciliation, exact digest, and exact origin revision

The failed run created no backup, recovery cluster, PVC, network policy, proof ConfigMap, or staging schema. Its cleanup job succeeded, so retrying after this change is deployed starts from the original fenced state.

@devantler

Copy link
Copy Markdown
Contributor Author

@codex review Please review the current head 92092f1, especially the exact pre-loss witness and the refusal-phase disclosure boundary.

@devantler

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 57 minutes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T21:07:07.073083Z 92092f1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 71ba0001-a785-4d6f-88a0-52177450021b

📥 Commits

Reviewing files that changed from the base of the PR and between ab9987a and 92092f1.

📒 Files selected for processing (2)
  • scripts/recover-wedding-db-incident.mjs
  • tests/wedding-db-incident-recovery/recovery.test.mjs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 92092f1232

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler
devantler marked this pull request as ready for review September 12, 2026 21:20
@devantler
devantler added this pull request to the merge queue Sep 12, 2026
Merged via the queue into main with commit 81cdcef Sep 12, 2026
29 checks passed
@devantler
devantler deleted the codex/wedding-db-recovery-witness-fix branch September 12, 2026 21:33
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant