Skip to content

security(vault-backup): stop the mirror inheriting a gid chosen for openbao #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devantler wants to merge 1 commit into from
Closed

security(vault-backup): stop the mirror inheriting a gid chosen for openbao #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion k8s/bases/infrastructure/vault-backup/cron-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,19 @@ spec:
# even when created before the webhook is active on fresh bring-up.
securityContext:
runAsUser: 65532
runAsGroup: 1000
# The pod default gid is the same high 65532, for the same reason the uid is:
# `minio/mc` bakes no group of its own, so a pod-level 1000 was an
# unjustified low-GID execution for the only container that inherits it. The
# snapshot container restates the openbao image's baked 100:1000 explicitly,
# so the annotation above covers just the execution its rationale accounts
# for rather than one more it does not.
#
# Reading the snapshot does NOT depend on the mirror's primary gid. fsGroup
# stays 1000: Kubernetes adds it to every container's supplementary groups
# and sets the setgid bit on the volume, so the 0640 snapshot lands group
# 1000 and a gid-65532 reader still opens it. Same mechanism vault-config
# relies on, verified there against a paired control (#3258).
runAsGroup: 65532
fsGroup: 1000
runAsNonRoot: true
seccompProfile:
Expand Down
14 changes: 13 additions & 1 deletion k8s/bases/infrastructure/vault-backup/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,19 @@ spec:
# even when created before the webhook is active on fresh bring-up.
securityContext:
runAsUser: 65532
runAsGroup: 1000
# The pod default gid is the same high 65532, for the same reason the uid is:
# `minio/mc` bakes no group of its own, so a pod-level 1000 was an
# unjustified low-GID execution for the only container that inherits it. The
# snapshot container restates the openbao image's baked 100:1000 explicitly,
# so the annotation above covers just the execution its rationale accounts
# for rather than one more it does not.
#
# Reading the snapshot does NOT depend on the mirror's primary gid. fsGroup
# stays 1000: Kubernetes adds it to every container's supplementary groups
# and sets the setgid bit on the volume, so the 0640 snapshot lands group
# 1000 and a gid-65532 reader still opens it. Same mechanism vault-config
# relies on, verified there against a paired control (#3258).
runAsGroup: 65532
fsGroup: 1000
runAsNonRoot: true
seccompProfile:
Expand Down
Loading