Repository navigation
Conversation
Contributor
Author
Closing this stale draft as superseded by the reviewed production contract now on main. Platform intentionally deploys the merge-group commit before merge so a failed production rollout blocks the queue, while direct pushes use the manual CD fallback. Both paths now share the exact-digest stage, verification, signing, attestation, promotion, reconciliation, and readiness proof in the deploy-prod action. Moving the normal deploy to a post-merge push would remove the rollback-before-merge safety property and regress the current deployment design. There is no remaining valid finding to carry forward from this draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
merge_group(merge-queue) refs from receiving production deployment secrets or mutating the production cluster by removing the automatic prod deploy path from the CI merge-queue workflow.mainafter merge or by explicit manual dispatch so deploys require the normal branch-based protections and reviewer controls.Description
deploy-prodandheal-prod-on-failurejobs from the CI workflow (.github/workflows/ci.yaml) so the merge-queue no longer restores production secrets or runsksailagainstksail.prod.yamlon speculative refs..github/workflows/cd.yaml) to trigger automatic production deploys onpushtomain(with path filters) while preserving manualworkflow_dispatchand the shared deploy composite action that accepts production secrets as inputs.mainor manual dispatch rather than the merge-queue.Testing
ruby -e 'require "yaml"; [".github/workflows/ci.yaml",".github/workflows/cd.yaml"].each{|f| YAML.load_file(f); puts "#{f}: ok"}', which succeeded.git diff --checkto ensure there are no whitespace or patch issues, which returned cleanly.rg -n "deploy-prod|environment: prod|secrets\.|github.event_name == 'merge_group'|prod-deploy" .github/workflows/ci.yaml .github/workflows/cd.yamlto confirm the prod deploy path was removed from CI and present only onmainin CD, which matched expectations.Codex Task