Skip to content

fix(github): restrict OCIRepository cosign subject to protected release tags #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devantler wants to merge 2 commits into from
Closed

fix(github): restrict OCIRepository cosign subject to protected release tags #2719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6d7b4
fix(github): restrict config artifact signer refs
devantler Jul 18, 2026
29895d7
Merge branch 'main' into codex/fix-github-config-oci-verification-issue
devantler Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions k8s/bases/apps/github-config/oci-repository.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,10 @@ spec:
# subjects are accepted via ONE regex-alternated entry — cosign's keyless
# attestation verification rejects MULTIPLE identity entries outright
# ("unsupported: multiple identities are not supported at this time"), so
# the transition must be expressed inside a single subject regex. Narrow
# the alternation to actions-only once the first actions-signed artifact
# has been published and verified.
# the transition must be expressed inside a single subject regex. Accept only
# protected release-tag invocations of the reusable signer; do not allow
# arbitrary branch or pull-request refs to publish higher-semver GitHub
# org-management artifacts. Narrow the alternation to actions-only once
# the first actions-signed artifact has been published and verified.
- issuer: '^https://token\.actions\.githubusercontent\.com$'
subject: '^https://github\.com/devantler-tech/(reusable-workflows|actions)/\.github/workflows/publish-manifests\.yaml@.+$'
subject: '^https://github\.com/devantler-tech/(reusable-workflows|actions)/\.github/workflows/publish-manifests\.yaml@refs/tags/v[0-9]+\.[0-9]+\.[0-9]+$'

@devantler devantler Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Keep the SHA-pinned signer identity accepted

The current producer in devantler-tech/.github/.github/workflows/cd.yaml invokes devantler-tech/actions/.github/workflows/publish-manifests.yaml@061b345a7351b0caf23055caea63ccd08b75e20e, so its Fulcio SAN ends in a 40-hex workflow ref, not refs/tags/v.... This tag-only matcher therefore rejects every currently produced github-config artifact and freezes Flux verification/reconciliation when the next artifact is selected. Platform main already fixed this in #2816 after checking the deployed 1.20.2 signature, using the actions-only ([0-9a-f]{40}|refs/tags/v.+) ref matcher. Preserve that SHA-or-tag shape (and drop the archived reusable-workflows alternative), with positive SHA/tag and negative floating-ref coverage.

Loading