Skip to content

fix(rgd): single regex-alternated cosign identity for tenant artifact verification - #2408

Merged
devantler merged 1 commit into
mainfrom
claude/rgd-cosign-single-identity
Jul 3, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/rgd-cosign-single-identity

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Daily AI Assistant

Why

RGD-instantiated tenants pin artifact verification to the reusable-workflows signing identity. When those tenants repoint their cd workflows to devantler-tech/actions (the actions#425 train), verification would fail — and adding a second identity entry is exactly what froze the apps layer yesterday (#2399 → #2404), since cosign rejects multiple identities outright.

What

The RGD template now uses the same single regex-alternated subject as the merged #2404, accepting both repos in one entry. Narrow to actions-only later with the #2404 cleanup.

Fixes #2405 · Relates to #2402

Note: local-overlay validation green (492 files); prod-overlay ksail workload validate hit the known kubeconform#363 render race repeatedly this session (shifting corruption lines in untouched helm-rendered CRDs) — kustomize builds of the affected layers pass.

…ted cosign identity

Same single-entry alternation as #2404 — cosign keyless attestation
verification rejects multiple matchOIDCIdentity entries, so the RGD
template must carry the alternation before any RGD tenant repoints its
cd workflow to devantler-tech/actions.

Fixes #2405

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The tenant ResourceGraphDefinition's cosign matchOIDCIdentity.subject regex was updated to accept OIDC identities from both reusable-workflows and actions workflow paths via regex alternation, replacing the previous single-path pattern. Inline comments were expanded to document this behavior.

Changes

OIDC Identity Matcher Update

Layer / File(s) Summary
Update subject regex alternation
k8s/bases/infrastructure/resource-graph-definitions/tenant/resource-graph-definition.yaml
Replaced single reusable-workflows-only subject pattern with a regex alternation accepting reusable-workflows or actions paths, and expanded comments explaining the identity-acceptance behavior and planned narrowing.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • devantler-tech/platform#2319: Both PRs modify the same cosign verify.matchOIDCIdentity.subject regex in a tenant/platform OCIRepository configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The change satisfies #2405 by updating the tenant RGD to use one alternated subject matching reusable-workflows and actions.
Out of Scope Changes check ✅ Passed The PR stays within scope; the only changes are the required matcher update and clarifying comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly summarizes the main change: using a single regex-alternated cosign identity for tenant artifact verification.
Description check ✅ Passed The description directly explains the cosign identity change and its purpose in the tenant RGD template.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/rgd-cosign-single-identity

Comment @coderabbitai help to get the list of available commands.

@devantler
devantler marked this pull request as ready for review July 3, 2026 07:39
@devantler
devantler added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit 871790f Jul 3, 2026
15 checks passed
@devantler
devantler deleted the claude/rgd-cosign-single-identity branch July 3, 2026 08:17
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Jul 3, 2026
@botantler-1

botantler-1 Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.95.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Tenant RGD's matchOIDCIdentity must follow the single-entry alternation before RGD tenants repoint

1 participant