Skip to content

chore(infrastructure): remove dead Testkube manifests - #2013

Merged
botantler-1[bot] merged 2 commits into
mainfrom
claude/goofy-brahmagupta-966bf3
Jun 11, 2026
Merged

botantler-1[bot] merged 2 commits into
mainfrom
claude/goofy-brahmagupta-966bf3

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Daily AI Assistant

What

Removes the orphaned k8s/bases/infrastructure/controllers/testkube/ tree (HelmRelease, HelmRepository, namespace, networkpolicy, and 14 vendored CRD files — ~27k lines) and the stale testkube namespace exemption in validate-replica-floor.yaml.

Why

This came out of a cost/efficiency sweep of the platform. Testkube is referenced by no kustomization: it is absent from the base controllers aggregate (k8s/bases/infrastructure/controllers/kustomization.yaml) and from both provider overlays, so it deploys to neither cluster. It was pure dead weight that still cost maintenance:

  • Renovate kept opening chart-bump PRs for it (e.g. fix(deps): update helm release testkube to v2.10.0 #1875 bumped it to v2.10.0), each triggering the full ~3–5 min system test for a chart that deploys nowhere.
  • Every ksail workload validate run schema-checked its ~50k lines of vendored CRDs.
  • The manifests shipped in every OCI artifact pushed to GHCR on every deploy.

The only reference outside its own directory was the testkube namespace exemption in the replica-floor policy, removed here too (the namespace no longer exists in any overlay).

Validation

  • ksail workload validate — ✅ 301 files validated
  • ksail --config ksail.prod.yaml workload validate — 88 kustomizations validated, 1 pre-existing failure: the datreeio coroot_v1 schema gap (notificationIntegrations not in the upstream CRDs-catalog yet — fixed upstream in Update coroot.com/coroot_v1 schema from coroot-operator 0.9.7 datreeio/CRDs-catalog#896, unrelated to this change)
  • kubectl kustomize k8s/clusters/local/ — ✅ builds
  • kubectl kustomize k8s/clusters/prod/ — ✅ builds

🤖 Generated with Claude Code

The testkube controller tree (HelmRelease, 14 vendored CRDs, namespace,
networkpolicy) is referenced by no kustomization: it is absent from the
base controllers aggregate and from both provider overlays, so it deploys
nowhere. It still cost maintenance — Renovate kept bumping its chart
(#1875) and every ksail validate run checked its ~50k lines of CRDs.

Also drops the stale `testkube` namespace exemption from
validate-replica-floor (the namespace no longer exists in any overlay).

Validation: ksail workload validate green (301 files); prod validate's
only failure is the pre-existing datreeio coroot_v1 schema gap (upstream
CRDs-catalog #896), unrelated; kubectl kustomize builds green for both
clusters.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@botantler-1
botantler-1 Bot enabled auto-merge June 11, 2026 16:14
@botantler-1
botantler-1 Bot added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit 7475553 Jun 11, 2026
10 checks passed
@botantler-1
botantler-1 Bot deleted the claude/goofy-brahmagupta-966bf3 branch June 11, 2026 16:45
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Jun 11, 2026
devantler added a commit that referenced this pull request Jun 11, 2026
…mponent)

The FQDN sweep originally pinned the testkube policy's world:443
egress, but main removed the entire dead testkube component, so the
policy file goes with it — 12 pinned policies remain.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@botantler-1

botantler-1 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.50.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This branch was previously deployed

1 inactive deployment
ci — 1e5238e0 Deployed Jun 11, 2026 by devantler via 🧪 System Test #2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant