Repository navigation
refactor(infrastructure): use path-only kustomize patches where self-identifying - #1929
Conversation
…identifying Patch entries mixed two equivalent styles — an explicit `target:` selector alongside `path:`, and `path:` alone — sometimes within the same file. Every strategic-merge patch file already carries full identity (apiVersion/kind/name/namespace), so its `target:` block just restated that and was redundant. Drop the redundant `target:` selectors and keep `path:` alone, matching the path-only style the hetzner overlays already use (and the convention the coroot patch comment documents). The one genuine exception — whoami's JSON6902 patch, which has no embedded identity — keeps its explicit target, now with a comment explaining why. Behavior-preserving: `kubectl kustomize` output for all three affected provider paths (docker controllers, hetzner apps, hetzner infrastructure) is byte-identical. `ksail workload validate` unchanged (local 0 failures; prod's only failure is the pre-existing coroot catalog-schema one). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # k8s/providers/docker/infrastructure/controllers/kustomization.yaml # k8s/providers/hetzner/apps/kustomization.yaml
![botantler-1[bot]](https://avatars.githubusercontent.com/in/1025824?s=60&v=4){kind=small}
|
The failing 🧪 System Test here is not caused by this PR — it's a pre-existing regression on This PR's change is render-neutral (path-only patch style); its flagger HelmRelease is byte-identical to Root cause: #1900 enabled flagger Fix in #1938 (changes the post-renderer to |
|
🎉 This PR is included in version 1.44.15 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
What
Kustomize patch entries mixed two equivalent styles — an explicit
target:selector next topath:, andpath:alone — sometimes in the same file. Since every strategic-merge patch file already carries full identity (apiVersion/kind/name/namespace), thetarget:block merely restated it and was redundant.Change
Drop the redundant
target:selectors, keepingpath:alone — the path-only style the hetzner overlays already use and that the coroot-patch comment documents. Converted 11 entries across 3 files:providers/docker/infrastructure/controllers— 7 HelmRelease/KubeVirt patchesproviders/hetzner/apps— 3 (ascoachingogvaner, headlamp, wedding-app)providers/hetzner/infrastructure— 1 (gateway-patch)Principled exception:
whoami's patch is JSON6902 (a list of ops, no embedded identity) so it genuinely requires atarget:— kept, now with a comment explaining why. The remaining mix is intentional and documented, not accidental.Validation (behavior-preserving)
kubectl kustomizefor all three affected provider paths is byte-identical to before.ksail workload validate: local 0 failures; prod unchanged (only the pre-existing coroot catalog-schema failure).🤖 Generated with Claude Code