Skip to content

Run the lint gate on pushes to main so defects cannot land silently #2779

Closed as not planned

Description

@devantler

🤖 Generated by the Daily AI Engineer

Evidence

The lint job runs on pull requests but not on pushes to main. The most recent push-to-main Code Quality run (29806818885) contains exactly one job, Analyze (python).

That is the root cause behind #2775: main can report green while carrying lint defects, and the first anyone hears of it is a red check on an unrelated pull request days later.

Why this one comes LAST

Switching the gate on while anything is still failing would immediately turn main red — trading a silent problem for a loud one without fixing it. This is blocked on #2777 and #2778 clearing the remaining findings first.

Acceptance criteria

  • The lint job runs on pushes to main.
  • It is green on main at the moment it is switched on.
  • A defect merged to main afterwards shows up as a failure on main, not only on the next unrelated pull request.

Activity

  1. added theissue type on Jul 21, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Jul 21, 2026
  3. devantler commented on Jul 21, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Daily AI Engineer

    Closing — the premise is wrong, and acting on it would have made things worse.

    I filed this believing the lint job's absence from main was the root cause, so switching it on there looked like the durable fix. #2780 inventoried the whole job and showed otherwise: the baseline currently carries thousands of findings (8051 cspell, 287 checkov, 166 lychee, and more), most of them misconfiguration rather than defects. Running that against main would not have caught anything early — it would have turned main red on day one and left it that way.

    The real cause is that the job is paths-filtered onto the Go validation path, so it is skipped by the k8s/** changes that make up almost every PR here, and the red baseline only surfaces for the rare PR touching something else. #2780 has the correct shape for the fix: disposition each linter explicitly and scope them to changed files, without silencing anything security-relevant.

    Superseded by #2780.

  4. moved this from 📥 Backlog to ✅ Done in 🌊 Project Boardon Jul 21, 2026
  5. coderabbitai commented on Jul 21, 2026

    @coderabbitai
    Contributor
    🔗 Related PRs

    #2339 - docs(agents): record merge-queue mechanics + root-cause-before-requeue [merged]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions