Skip to content

Re-enable Go Code Quality after preview gate matures #2751

Closed

Description

@devantler

🤖 Generated by the Daily AI Engineer (Codex instance)

Objective

Re-enable Go in GitHub Code Quality once the preview gate can analyze Go safely without turning a no-Go PR head into a repository-wide merge blocker.

Details

Platform temporarily reduced Code Quality from go, python to python on 2026-07-19 after the maintainer selected that reversible mitigation on #2746. Code Security remains unchanged on actions, go, python, and ordinary Go CI remains required.

The temporary reduction is settings-only because the deployed GitHub provider does not expose the Code Quality setup surface. GitHub's versioned REST endpoint is the current control plane.

Checklist

  • On or after 2026-10-19, verify whether GitHub Code Quality is generally available or its Go analysis no longer configuration-errors when a PR head contains no Go.
  • Verify the repository's real language inventory and keep Python only while Python files remain.
  • Re-enable Go through PATCH /repos/devantler-tech/platform/code-quality/setup only after a representative Go-bearing PR and a no-Go/config-only PR both have passing Code Quality runs.
  • Re-read Code Security default setup afterward and prove it still analyzes actions, go, python (or the then-current real inventory).
  • Move the setting into declarative organisation configuration when the deployed provider exposes Code Quality; until then, record the exact reversible API state on this issue.

Dependencies

Blocked on a named external dependency: GitHub Code Quality reaching GA or changing the preview Go/no-source behavior. Public product documentation is the verification surface; no external repository inspection is required.

Related to #2746.

Activity

  1. added theissue type on Jul 19, 2026
  2. coderabbitai commented on Jul 19, 2026

    @coderabbitai
    Contributor
    🔗 Related PRs

    #2273 - ci: re-enable in-process Helm render in validate (revert --skip-helm-render) [merged]
    #2339 - docs(agents): record merge-queue mechanics + root-cause-before-requeue [merged]
    #2622 - fix(ci): heal cancelled merge-group deploys [merged]


    📝 Issue Planner

    Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.

    • Create Plan

    🧪 Issue enrichment is currently in open beta.

    You can configure auto-planning by selecting labels in the issue_enrichment configuration.

    To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

    issue_enrichment:
      auto_enrich:
        enabled: false

    💬 Have feedback or questions? Drop into our discord!

  3. devantler commented on Jul 19, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Daily AI Engineer (Codex instance)

    Board claim: setting this newly created issue's statusless Project 5 item to 📥 Backlog now. No view or other item will be changed.

  4. moved this to 📥 Backlog in 🌊 Project Boardon Jul 19, 2026
  5. devantler commented on Jul 19, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Daily AI Engineer (Codex instance)

    Board claim complete: Project 5 status is now 📥 Backlog.

  6. devantler commented on Aug 25, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    The dependency has SHIPPED — blocked removed

    Part of the sweep in monorepo#3052. This
    issue carried blocked with no **Blocker:** line. Adding one was the obvious repair; verifying it
    first was the right one, because the blocker no longer exists.

    GitHub Code Quality reached general availability on 2026-07-20, announced in GitHub's own
    changelog. Verified 2026-08-25 from public, non-repository sources only — the changelog and product
    documentation — per the contract's rules for confirming an external blocker.

    This issue's own checklist said to check "on or after 2026-10-19" whether Code Quality "is
    generally available or its Go analysis no longer configuration-errors"
    . The first disjunct has been
    true for over a month, so the date gate was holding the work well past its own condition. The
    contract is explicit on what follows: "If the dependency has shipped, remove the blocked label
    and blocker line and resume oldest-first."

    What this does and does not settle

    GA satisfies the stated condition, but it is not by itself evidence that the specific failure
    mode has gone. That failure mode was Go analysis config-erroring on a PR head containing no Go, and
    nothing in the GA announcement speaks to it. So the checklist's remaining verification steps stand
    unchanged and still gate the actual re-enablement:

    • confirm the no-Go-head behaviour directly, on a representative Go-bearing PR and a
      config-only PR, before flipping anything;
    • re-read Code Security default setup afterwards and prove it still analyses the real inventory.

    One thing to weigh that did not exist when this was filed: GA started billing on 2026-07-20, at
    $10 per active committer per month on enabled repositories. This repository already has Code Quality
    enabled for python, so the per-committer charge is already being incurred and adding Go back does
    not change it — the pricing is per active committer on an enabled repository, not per language. Worth
    stating explicitly so the re-enablement is not mistaken for a new cost, and worth confirming against
    the actual invoice rather than the price page before anyone relies on it.

    Returned to the normal queue as ordinary Chore work.

    Sources: GitHub Code Quality is now generally available · About GitHub Code Quality

  7. devantler commented on Oct 4, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    Verified the current outcome on 2026-10-04 UTC without changing settings: Code Quality is configured for go and javascript-typescript. Code Security remains configured for actions, go and the JavaScript/TypeScript inventory. Python is absent from both setup responses and from the newly merged tracked source inventory.

    Both representative paths pass Go Code Quality: the Go-bearing flag guard run, and the configuration-only PR #4463 run, whose four changed files are configuration files with no Go changes. The current platform already contains Go source at every normal PR head, and the live setup is enabled; this is acceptance of the existing configuration, not a new preview-enablement experiment.

    Closing the re-enablement task as already delivered and now verified. Declarative adoption remains conditional on the provider exposing the setup API; no provider capability or settings write is claimed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Fields

    Priority

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions