Repository navigation
feat(observability): retire Loki and Alloy from Coroot profiles - #97
Conversation
Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
Validated exact head
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c3d53e0a95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
The Grafana-source finding is fixed at At this head, the focused gate, its dead-source ablation, naming, shared-policy, recommended-label, local KSail, and prod KSail validations all pass. Both KSail runs validated 97 kustomizations and 258 files without starting a cluster. @codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
What changed
HelmRelease/loki,HelmRelease/alloy,HelmRelease/alloy-audit, and their now-unconsumedHelmRepository/grafanafrom both providersHelmRepository/ciliumkube-prometheus-stackremains until the metrics/alerting slice is proven separatelyWhy
Selecting Coroot still deployed a second logging backend and collector path that the reference Platform no longer carries. Loki and Alloy form one coupled path, so retiring them together is the smallest coherent step toward #65 without also changing metrics or alerting.
Validation
alloy-audit./scripts/validate-observability-option.shHelmRepository/grafana./scripts/validate-naming.sh./scripts/validate-shared-cluster-policies.sh./scripts/validate-recommended-labels-option.shksail --config ksail.yaml workload validate(97 kustomizations, 258 files)ksail --config ksail.prod.yaml workload validate(97 kustomizations, 258 files)KSail emitted the existing Testkube OCI-render warning and validated those HelmRelease resources as-is; both commands exited 0.
User-path evaluation
Rendered the default and selectable Coroot profiles through the documented static operator path. Defaults match
origin/mainbyte-for-byte and retain Loki, both Alloy releases, and their Grafana source. Each Coroot profile has none of those releases, their datasource, or the unconsumed chart source, and keeps the documented Coroot activation path valid. Per this template's safety contract, no cluster was started or mutated.Fixes #96
Part of #65