Skip to content

fix(apps): remove the Headlamp demo app - #270

Merged
devantler merged 1 commit into
mainfrom
claude/remove-headlamp
Oct 26, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/remove-headlamp

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

Headlamp is being retired from the platform (devantler-tech/platform#2496), and the KSail web UI is taking over as the cluster UI (devantler-tech/ksail#5827). New platforms made from this template should not start with a UI the suite no longer uses.

What

Removes the Headlamp demo app and everything that existed only for it: its sign-in callback, network and autoscaling allowances, security-scan exceptions, settings, local host name and docs. The optional Coroot observability profile still renders and removes exactly what it did before.

Part of devantler-tech/platform#2496

👉 After merge/promotion: platforms already created from this template keep their own Headlamp settings and host names until they remove them.

🤖 Generated with Claude Code

Headlamp is retired from the platform (devantler-tech/platform#2496) and
the KSail web UI is taking over its role (devantler-tech/ksail#5827), so
new platforms should not start with it. Remove the app with its Dex
callback, network allowances, KEDA grant, security-exception namespaces,
replica variable, local host name and docs.

The Coroot observability components edit Dex callbacks and exception
namespaces by list position, so their guarded indices move with the
removed entries, and the OpenCost plugin patch that only targeted
Headlamp goes. The observability check now requires a real apps render
before it accepts the absence of OpenCost references.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: db7a3426-6ad8-4bdc-afd0-40c891e89b2c
Commits

Reviewing files that changed from the base of the PR and between 080691e and d01b000.

Files selected for processing: 34
  • .github/retired-repo-links.json
  • AGENTS.md
  • docs/ARCHITECTURE.md
  • docs/TEMPLATING.md
  • docs/TENANTS.md
  • hosts
  • k8s/bases/apps/headlamp/README.md
  • k8s/bases/apps/headlamp/cilium-network-policy.yaml
  • k8s/bases/apps/headlamp/external-secret.yaml
  • k8s/bases/apps/headlamp/helm-release.yaml
  • k8s/bases/apps/headlamp/helm-repository.yaml
  • k8s/bases/apps/headlamp/http-route.yaml
  • k8s/bases/apps/headlamp/http-scaled-object.yaml
  • k8s/bases/apps/headlamp/kustomization.yaml
  • k8s/bases/apps/headlamp/namespace.yaml
  • k8s/bases/apps/headlamp/persistent-volume-claim.yaml
  • k8s/bases/apps/kustomization.yaml
  • k8s/bases/infrastructure/cluster-security-exceptions/controller-rbac.yaml
  • k8s/bases/infrastructure/cluster-security-exceptions/health-probes.yaml
  • k8s/bases/infrastructure/cluster-security-exceptions/service-account-tokens.yaml
  • k8s/bases/infrastructure/controllers/dex/cilium-network-policy.yaml
  • k8s/bases/infrastructure/controllers/dex/helm-release.yaml
  • k8s/bases/infrastructure/controllers/keda-http-add-on/reference-grant.yaml
  • k8s/bases/infrastructure/controllers/keda/cilium-network-policy.yaml
  • k8s/bases/infrastructure/controllers/opencost/cilium-network-policy.yaml
  • k8s/bases/infrastructure/controllers/opencost/helm-release.yaml
  • k8s/bases/infrastructure/external-secrets/grafana-oidc.yaml
  • k8s/clusters/prod/bootstrap/variables-cluster-config-map.yaml
  • k8s/components/observability-coroot/remove-kps-ui/kustomization.yaml
  • k8s/components/observability-coroot/remove-opencost-references/kustomization.yaml
  • k8s/providers/docker/apps/headlamp/patches/trust-platform-ca.yaml
  • k8s/providers/docker/apps/kustomization.yaml
  • k8s/providers/hetzner/infrastructure/cluster-issuers/cloudflare-origin-ca-trust-bundle.yaml
  • scripts/validate-observability-option.sh
Files with no reviewable changes: 20
  • k8s/bases/apps/headlamp/namespace.yaml
  • hosts
  • k8s/bases/apps/headlamp/persistent-volume-claim.yaml
  • k8s/providers/docker/apps/headlamp/patches/trust-platform-ca.yaml
  • k8s/bases/apps/headlamp/README.md
  • k8s/bases/apps/headlamp/http-route.yaml
  • k8s/bases/apps/kustomization.yaml
  • k8s/bases/apps/headlamp/kustomization.yaml
  • .github/retired-repo-links.json
  • docs/ARCHITECTURE.md
  • k8s/bases/apps/headlamp/external-secret.yaml
  • k8s/bases/apps/headlamp/helm-repository.yaml
  • k8s/bases/apps/headlamp/http-scaled-object.yaml
  • k8s/bases/apps/headlamp/helm-release.yaml
  • k8s/bases/infrastructure/controllers/keda/cilium-network-policy.yaml
  • k8s/bases/infrastructure/controllers/dex/helm-release.yaml
  • k8s/bases/apps/headlamp/cilium-network-policy.yaml
  • k8s/bases/infrastructure/controllers/keda-http-add-on/reference-grant.yaml
  • k8s/clusters/prod/bootstrap/variables-cluster-config-map.yaml
  • k8s/providers/docker/apps/kustomization.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Additional comments: 14
AGENTS.md: 1

59-59: LGTM!

docs/TEMPLATING.md: 1

76-77: LGTM!

Also applies to: 253-253

docs/TENANTS.md: 1

3-3: LGTM!

k8s/bases/infrastructure/cluster-security-exceptions/controller-rbac.yaml: 1

5-7: LGTM!

Also applies to: 19-20

k8s/bases/infrastructure/cluster-security-exceptions/health-probes.yaml: 1

6-8: LGTM!

k8s/bases/infrastructure/cluster-security-exceptions/service-account-tokens.yaml: 1

5-5: LGTM!

Also applies to: 14-17

k8s/bases/infrastructure/controllers/dex/cilium-network-policy.yaml: 1

27-27: LGTM!

k8s/bases/infrastructure/controllers/opencost/cilium-network-policy.yaml: 1

19-23: LGTM!

k8s/bases/infrastructure/controllers/opencost/helm-release.yaml: 1

30-30: LGTM!

Also applies to: 130-130

k8s/bases/infrastructure/external-secrets/grafana-oidc.yaml: 1

18-18: LGTM!

k8s/providers/hetzner/infrastructure/cluster-issuers/cloudflare-origin-ca-trust-bundle.yaml: 1

3-3: LGTM!

k8s/components/observability-coroot/remove-kps-ui/kustomization.yaml: 1

86-86: LGTM!

Also applies to: 89-89, 91-91, 94-94, 96-96, 99-99

k8s/components/observability-coroot/remove-opencost-references/kustomization.yaml: 1

9-9: LGTM!

Also applies to: 239-239, 242-242, 252-253, 262-263, 297-297, 300-300

scripts/validate-observability-option.sh: 1

1049-1055: LGTM!

Also applies to: 1300-1300

Walkthrough

The change removes Headlamp from the platform template, including its Kubernetes resources, provider configuration, and related infrastructure references. It also removes Headlamp from app inventories and updates Coroot overlay patches and observability-option validation.

Possibly related issues

  • devantler-tech/ksail#5827: The issue covers long-term Headlamp retirement, which this change advances by removing Headlamp from the platform template.
  • devantler-tech/platform#2496: The issue tracks platform-side Headlamp removal, and this change removes its template resources and references.

Priority: Low

Merge Risk: Minimal · up to d01b0

The retired Headlamp app is removed without an identified impact on the remaining applications or observability profiles.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "fix(apps): remove the Headlamp demo app" matches the main change. The changeset deletes the Headlamp demo app's manifests, HelmRelease, network policy, ExternalSecret, HTTPRoute, scaling ob…
Description check Passed The description explains why Headlamp is removed (platform retirement and the KSail web UI replacing it). It lists what is removed, including the sign-in callback, network and autoscaling allowances, …
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (13 skipped: 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(apps): remove the Headlamp demo app" matches the main change. The changeset deletes the Headlamp demo app's manifests, HelmRelease, network policy, ExternalSecret, HTTPRoute, scaling object, Dex callback, and related docs and settings. The title is specific and concise. It uses a conventional-commit prefix, which is consistent with the repository style.

Full details: Description check

Explanation

The description explains why Headlamp is removed (platform retirement and the KSail web UI replacing it). It lists what is removed, including the sign-in callback, network and autoscaling allowances, security-scan exceptions, settings, host name, and docs. It also states that the Coroot profile should keep its behavior and that existing platforms keep their own Headlamp settings. This matches the changeset.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (13 skipped: 13 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 Checkov (3.3.25)
k8s/components/observability-coroot/remove-kps-ui/kustomization.yaml

Checkov retry budget exhausted before isolating this batch

k8s/components/observability-coroot/remove-opencost-references/kustomization.yaml

Checkov retry budget exhausted before isolating this batch

k8s/providers/hetzner/infrastructure/cluster-issuers/cloudflare-origin-ca-trust-bundle.yaml

Checkov retry budget exhausted before isolating this batch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler
devantler marked this pull request as ready for review October 26, 2026 19:14
@devantler
devantler requested a review from a team as a code owner October 26, 2026 19:14
@devantler
devantler merged commit a87e65b into main Oct 26, 2026
19 checks passed
@devantler
devantler deleted the claude/remove-headlamp branch October 26, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant