Repository navigation
feat(flux): define HelmRelease retry defaults and drift detection once as components - #204
Conversation
…e as components Every provider layer that renders HelmReleases now applies two shared Kustomize components: the install/upgrade remediation block the flux best-practice policy requires, and drift detection with the runtime-owned fields ignored. The remediation block is removed from each HelmRelease, which inherits it instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecf781f519
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… the provider layers A consumer of a single base now gets the retry defaults and drift detection too, instead of depending on every provider layer to import them. Also records why the whole webhooks list is ignored: a JSON Pointer cannot select one field in every array entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Readiness at
Promoting and merging at this head. |
Why
Every chart the template installs repeats the same retry settings, so a new chart can easily miss them. Nothing notices when a chart's resource is deleted or edited by hand, so a platform can look healthy while part of it is gone. The reference platform already solves both once, centrally; new platforms built from this template did not get that.
What
The retry settings and drift detection are now defined once and applied to every chart in every environment, and the copies inside each chart are gone. Flux now restores a chart's resource that is deleted or changed out of band, while leaving alone the fields other controllers legitimately change at runtime. The docs describe the new shared pieces.
Fixes #68