Skip to content

fix(eks): wait for stopped capacity before restoring workers - #8282

Draft
devantler wants to merge 1 commit into
mainfrom
codex/eks-stop-start-7721
Draft

devantler wants to merge 1 commit into
mainfrom
codex/eks-stop-start-7721

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Starting an EKS cluster immediately after stopping it can report success while AWS is still scaling the workers down. That also discards the sizes needed to recover the cluster.

What

KSail checks that stop has taken effect before restoring workers and keeps their saved sizes until AWS reports the restored capacity. The EKS smoke test checks both transitions independently.

Part of #7721

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

The production stop/start regression fails on the current main source because the first immediate start returns success over a stale pre-stop read. The signed candidate requires a complete zero-capacity observation before issuing the first restore. Saved capacities survive a pending stop, an interrupted restore, and a repeated stop.

The provider and state packages and full CI harness passed locally. The EKS smoke workflow now compares the complete managed-nodegroup set and desired/minimum/maximum sizes before stop, after stop, and after start. It uses a bounded poll for both transitions. Workflow lint and strict Go lint passed. Native CI and the live EKS capacity and cleanup readbacks remain pending.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@github-code-quality

Copy link
Copy Markdown
Contributor

Code coverage overview

Languages: Go

Go / code-coverage/go

main 8f46ce7 codex/eks-stop-start... 2d0d217 +/-
71% 71% 0%
View coverage of the 4 most impacted files.
File main 8f46ce7 codex/eks-stop-start... 2d0d217 +/-
pkg/cli/cluster...i/distconfig.go 80% 78% -2%
pkg/svc/install...site_removal.go 92% 90% -2%
pkg/svc/provide...aws/provider.go 74% 74% 0%
pkg/svc/provide...egroup_state.go 73% 74% +1%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for EKS lifecycle state consistency across repeated or interrupted stop and start

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T00:06:32.361785Z 2d0d217 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 2d0d217c23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🫴 Ready

Development

Successfully merging this pull request may close these issues.

1 participant