Skip to content

fix(security): patch Go and HTTP/2 vulnerabilities - #7641

Merged
devantler merged 1 commit into
mainfrom
codex/go-security-patches-7640
Oct 9, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/go-security-patches-7640

Conversation

@devantler

@devantler devantler commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

New Go security advisories now affect KSail's compiler and HTTP/2 dependency and make the required vulnerability scan fail. Patched releases let us remove the exposure without accepting or suppressing those findings.

What

Update the compiler and affected dependency to their patched versions, keeping the analysis image aligned. All existing security checks and unrelated risk acceptances remain enabled.

Fixes #7640.

@devantler devantler left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

Self-review (fallback — CodeRabbit, Codex and Cursor Bugbot unavailable)

Reviewed commit: fe406f3

  • CodeRabbit: KSail's authenticated current refusal at #7633 (comment) and its edited summary, updated 2026-10-09T00:18:42Z/00:18:39Z, report both included reviews used and the next included review in 30 minutes, until 00:48:39Z. This included-review limit applies to this repository. No paid usage is authorized.
  • Codex: freshly read authenticated account usage-limit notice devantler-tech/monorepo#3992 (comment), updated 2026-10-08T17:01:34Z; no stated reset, maintainer-only recovery. The fresh lane-health receipt reports no serving recovery.
  • Cursor Bugbot: freshly read authenticated public user/team usage-limit notice devantler-tech/business-site#2 (comment), updated 2026-10-08T15:43:03Z; no stated reset, maintainer-only recovery. The fresh lane-health receipt reports no serving recovery.

I reviewed all five changed files against freshly fetched main. The module resolver changes only Go's patch floor and x/net's version/checksums. Both actual official Linux archives match the Dockerfile digests, and the smoke expectation/fixture agree with the patched compiler. The publisher's restricted real-image verification, signing, anonymous-pull requirements and disabled ARC activation remain unchanged. No vulnerability acceptance, release audit, check or runtime ownership boundary is loosened. Complete current-PR comments, reviews, threads and check-runs contain no reported finding or current provider verdict.

The full Go suite, CLI build, affected lint and actual isolated local/EKS CLI initialization pass. The exact native scanner v1.8.0 whole-root scan at Go 1.26.9, source/symbol mode, official DB modified 2026-10-08T22:31:09Z, removes all thirteen new reachable findings; remaining reachable IDs are entirely within the unchanged allowlist. Real native CI and image smoke remain delivery gates.

Verdict: no P0/P1 findings

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Verified at head fe406f3a72042eab6207563774a6e75092c8e1e6: the full root Go suite, actual CLI build, affected lint, module hygiene and isolated local/EKS initialization pass with Go 1.26.9 and x/net v0.60.0. Both actual official Linux Go archives match the pinned digests.

The complete source/symbol scan uses CI's exact govulncheck v1.8.0 with the official database modified 2026-10-08T22:31:09Z. All thirteen newly blocking advisory IDs are absent from reachable findings; every remaining reachable ID matches the unchanged allowlist. No exception was added or audit weakened.

Native image verification job 113610395939 also passed at this exact head: it built the actual Linux image and executed runner bootstrap plus the desktop compiler under the restricted container settings. This is image validation; publication and Platform activation remain separate outcomes.

Current-head fallback review 5464467334 passes the structural green-review helper under the freshly verified three-provider limits. Required native source, security, desktop and Docker gates must still settle before normal merge.

@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Go

Go / code-coverage/go

The overall line coverage in commit fe406f3 in the codex/go-security-pa... branch remains at 71%, unchanged from commit 343e086 in the main branch.

Show a line coverage summary of the most impacted files.
File main 343e086 codex/go-security-pa... fe406f3 +/-
pkg/client/reconciler/poll.go 87% 80% -7%
pkg/svc/provisi...etzner/token.go 77% 73% -4%
pkg/cli/cluster...i/distconfig.go 79% 78% -1%
pkg/svc/provisi...base/bringup.go 90% 93% +3%
pkg/client/helm/client.go 50% 54% +4%
pkg/client/helm...ux_ownership.go 0% 94% +94%

@devantler
devantler marked this pull request as ready for review October 9, 2026 01:40
@devantler
devantler merged commit 4dfe77d into main Oct 9, 2026
21 checks passed
@devantler
devantler deleted the codex/go-security-patches-7640 branch October 9, 2026 01:40
@devantler

devantler commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Merged through the normal protected squash path at 4dfe77d7047844235647a91331c1cdd261409fd8; #7640 is closed. At reviewed head fe406f3, all 27 actual Docker cluster trials, managed and owned Go analysis, vulnerability scan, Go/build/lint/coverage and desktop checks completed without failure. The exact-head review was green with zero unresolved threads, and GitHub reported CLEAN immediately before the bound-head merge.

The merged main source tree exactly matches the tested tree. Post-merge Git and Go module discovery confirm the source is the isolated KSail checkout. Go's local VCS discovery recognizes Git directories but skips the worktree's Git file, which explains its earlier surrounding-repository stamp. Binding only this build's Git subprocesses to the verified worktree corrects that limitation while keeping VCS stamping enabled. The rebuilt CLI now reports the full merged revision, an unmodified source tree, Go 1.26.9 and x/net v0.60.0. Explicit metadata assertions and isolated local/EKS initialization pass.

Release tagging succeeded. The main analysis-image build then failed fetching pinned Ubuntu packages with upstream HTTP 500/502/503 responses. The exact pinned endpoint subsequently returned HTTP 206, and current main still matched this commit, so I requested one failed-job retry. That retry also failed at Verify restricted analysis toolchain, and publication was skipped. Its retrieved log confirms HTTP 503 responses for all five pinned Ubuntu/Git PPA snapshot indexes, followed by apt exit 100. Every snapshot/version/checksum pin, restricted smoke check, signature and anonymous-pull gate remains enabled. Signed publication and Platform activation remain blocked on successful acquisition and validation of the pinned inputs.

devantler added a commit that referenced this pull request Oct 9, 2026
…#7266)

* fix(deps): bump github.com/fluxcd/pkg/apis/meta from 1.31.0 to 1.32.0

Bumps [github.com/fluxcd/pkg/apis/meta](https://github.com/fluxcd/pkg) from 1.31.0 to 1.32.0.
- [Commits](fluxcd/pkg@apis/meta/v1.31.0...apis/meta/v1.32.0)

---
updated-dependencies:
- dependency-name: github.com/fluxcd/pkg/apis/meta
  dependency-version: 1.32.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix(deps): bump github.com/hetznercloud/hcloud-go/v2 (#7627)

Bumps [github.com/hetznercloud/hcloud-go/v2](https://github.com/hetznercloud/hcloud-go) from 2.47.0 to 2.49.0.
- [Release notes](https://github.com/hetznercloud/hcloud-go/releases)
- [Changelog](https://github.com/hetznercloud/hcloud-go/blob/main/CHANGELOG.md)
- [Commits](hetznercloud/hcloud-go@v2.47.0...v2.49.0)

---
updated-dependencies:
- dependency-name: github.com/hetznercloud/hcloud-go/v2
  dependency-version: 2.49.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(deps): bump devantler-tech/ksail/.github/actions/free-disk-space (#7632)

Bumps [devantler-tech/ksail/.github/actions/free-disk-space](https://github.com/devantler-tech/ksail) from 7.202.4 to 7.202.15.
- [Release notes](https://github.com/devantler-tech/ksail/releases)
- [Commits](32f92ac...3115397)

---
updated-dependencies:
- dependency-name: devantler-tech/ksail/.github/actions/free-disk-space
  dependency-version: 7.202.15
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* test(ci): accept any full commit pin for the binary restore action (#7634)

The workflow contract compared the restore action's reference with one
literal revision. The dependency bot moves that revision with every release,
so each of its updates failed this test (#7630). The contract now requires
what it is there for: this repository's action at a full commit, never a
branch or a tag.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

* fix(deps): bump go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp (#7626)

Bumps [go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp](https://github.com/open-telemetry/opentelemetry-go) from 0.21.0 to 0.22.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@log/v0.21.0...log/v0.22.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp
  dependency-version: 0.22.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(deps): bump devantler-tech/.github/.github/workflows/validate-go-project.yaml from 7.2.11 to 7.8.5 (#7631)

* fix(deps): bump devantler-tech/.github/.github/workflows/validate-go-project.yaml

Bumps [devantler-tech/.github/.github/workflows/validate-go-project.yaml](https://github.com/devantler-tech/.github) from 7.2.11 to 7.8.5.
- [Release notes](https://github.com/devantler-tech/.github/releases)
- [Commits](devantler-tech/.github@ef34177...fca583a)

---
updated-dependencies:
- dependency-name: devantler-tech/.github/.github/workflows/validate-go-project.yaml
  dependency-version: 7.8.5
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* test(ci): admit the audited Go validation workflow revision

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>

* fix(deps): bump devantler-tech/ksail/.github/actions/restore-ksail-binary from 7.202.3 to 7.202.15 (#7630)

* fix(deps): bump devantler-tech/ksail/.github/actions/restore-ksail-binary

Bumps [devantler-tech/ksail/.github/actions/restore-ksail-binary](https://github.com/devantler-tech/ksail) from 7.202.3 to 7.202.15.
- [Release notes](https://github.com/devantler-tech/ksail/releases)
- [Commits](f9172ab...3115397)

---
updated-dependencies:
- dependency-name: devantler-tech/ksail/.github/actions/restore-ksail-binary
  dependency-version: 7.202.15
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* test(ci): align the audited binary restore action pin

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>

* fix(talos): strip storage registration labels from autoscaler workers (#7636)

* fix: respect Flux ownership without Helm storage labels (#7639)

* fix: respect Flux ownership without Helm storage labels

* chore: apply golangci-lint fixes

---------

Co-authored-by: ksail-bot[bot] <262010955+ksail-bot[bot]@users.noreply.github.com>

* ci: reject retired repository links in active documentation (#7529)

* ci: reject retired repository links in active documentation

* chore(ci): label the pinned checkout release accurately

* fix(ci): quote the retired link guard workspace setting

* chore: Apply megalinter fixes

---------

Co-authored-by: ksail-bot[bot] <262010955+ksail-bot[bot]@users.noreply.github.com>

* fix(security): patch Go and HTTP/2 vulnerabilities (#7641)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nikolai Emil Damm <ned@devantler.tech>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Nikolai Emil Damm <nikolaiemildamm@icloud.com>
Co-authored-by: ksail-bot[bot] <262010955+ksail-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Patch newly published Go and HTTP/2 vulnerabilities

1 participant