Skip to content

fix(auto-merge): retain pending evaluations by default on required runs - #741

Merged
devantler merged 1 commit into
mainfrom
claude/auto-merge-queue-default-277
Oct 25, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/auto-merge-queue-default-277

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

When several pull-request events arrive close together, the organization-wide auto-merge gate can quietly drop the evaluation that was waiting in line. A dropped evaluation can be a missed disarm, so a pull request may stay armed on review evidence that has since been withdrawn. Three repositories have run with the fix switched on since early October without problems, and the gate now runs from this repository, so the fix can apply everywhere through reviewed code instead of per-repository settings.

What

The organization-wide auto-merge gate now keeps every waiting evaluation by default, in arrival order. A repository or the whole organization can return to the old behaviour with one setting, and reusable-workflow callers keep their current behaviour.

Fixes #286

Part of #277

🤖 Generated with Claude Code

Direct and organization-required runs of the auto-merge gate now keep
every pending evaluation unless QUEUE_PENDING_EVALUATIONS is false, so a
burst of events can no longer drop a disarm. workflow_call callers keep
following their own input.

Fixes #286
Part of #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@devantler devantler added the bug label Oct 24, 2026
@github-code-quality

github-code-quality Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 1e50f42 claude/auto-merge-qu... 0308b6f +/-
50% 50% 0%

C# / code-coverage/dotnet

main 1e50f42 claude/auto-merge-qu... 0308b6f +/-
100% 100% 0%

Go / code-coverage/go

main 1e50f42 claude/auto-merge-qu... 0308b6f +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 24, 2026 22:21 UTC

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1e50f42 and 0308b6f.

Files selected for processing: 3
  • .github/tests/test-enable-auto-merge-author-gate.sh
  • .github/workflows/enable-auto-merge.yaml
  • README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T00:12:54.607506Z 0308b6f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 0308b6f9c0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at signed head 0308b6f9c0e0b4cd6ddb5eb1de1b1b092be98c3d. The complete native CI run has 237 unique jobs: 197 successful and 40 expected skips. The full current rollup is settled and GitHub reports CLEAN. Canonical thread read: zero unresolved; no thread or non-thread findings remain. Codex's substantive current-head review is clean. CodeRabbit declined the scoped request for its included-review limit; that service refusal supplies no review verdict.

The native three-slot queue control executed every slot successfully in sequence. The production-expression, trusted-actor, cancellation and reusable-call compatibility controls passed. The changed declaration retains pending direct/required evaluations by default while preserving deliberate actor-enforced cancellation and explicit reusable input behavior. The source and documentation were inspected together against those native results. Post-merge source adoption and the remaining input lifecycle under #277 remain separate acceptance work.

This finishes the reviewed source increment for #286; no production, permission or publisher bypass is involved.

@devantler
devantler marked this pull request as ready for review October 25, 2026 00:23
@devantler
devantler merged commit d3f31a2 into main Oct 25, 2026
268 checks passed
@devantler
devantler deleted the claude/auto-merge-queue-default-277 branch October 25, 2026 00:30
devantler added a commit that referenced this pull request Nov 7, 2026
* fix(auto-merge): retain pending evaluations on every run

The queued evaluation default has run on required runs since #741 and on
three opted-in repositories since early October. Retire the temporary
activation plumbing: every non-cancelling run and both mutation jobs now
keep every pending evaluation, and the QUEUE_PENDING_EVALUATIONS opt-out
is no longer read. The queue-pending-evaluations input stays declared and
ignored so callers that still pass it keep validating. Actor-enforced
cancellation keeps the single queue that GitHub requires.

Fixes #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(auto-merge): fail closed when the retired-input check cannot read the workflow

Capture the workflow read before searching it, so a yq failure fails the
test instead of matching nothing, and drop a stale "when opted in" from
the README now that every run queues.

Fixes #277

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-merge gate can silently skip an evaluation: adopt concurrency.queue: max

1 participant