Repository navigation
fix(auto-merge): retain pending evaluations by default on required runs - #741
Conversation
Direct and organization-required runs of the auto-merge gate now keep every pending evaluation unless QUEUE_PENDING_EVALUATIONS is false, so a burst of events can no longer drop a disarm. workflow_call callers keep following their own input. Fixes #286 Part of #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code coverage overviewLanguages: Go, C# Go / code-coverage/test
C# / code-coverage/dotnet
Go / code-coverage/go
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
@coderabbitai review |
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Ready at signed head The native three-slot queue control executed every slot successfully in sequence. The production-expression, trusted-actor, cancellation and reusable-call compatibility controls passed. The changed declaration retains pending direct/required evaluations by default while preserving deliberate actor-enforced cancellation and explicit reusable input behavior. The source and documentation were inspected together against those native results. Post-merge source adoption and the remaining input lifecycle under #277 remain separate acceptance work. This finishes the reviewed source increment for #286; no production, permission or publisher bypass is involved. |
* fix(auto-merge): retain pending evaluations on every run The queued evaluation default has run on required runs since #741 and on three opted-in repositories since early October. Retire the temporary activation plumbing: every non-cancelling run and both mutation jobs now keep every pending evaluation, and the QUEUE_PENDING_EVALUATIONS opt-out is no longer read. The queue-pending-evaluations input stays declared and ignored so callers that still pass it keep validating. Actor-enforced cancellation keeps the single queue that GitHub requires. Fixes #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(auto-merge): fail closed when the retired-input check cannot read the workflow Capture the workflow read before searching it, so a yq failure fails the test instead of matching nothing, and drop a stale "when opted in" from the README now that every run queues. Fixes #277 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Why
When several pull-request events arrive close together, the organization-wide auto-merge gate can quietly drop the evaluation that was waiting in line. A dropped evaluation can be a missed disarm, so a pull request may stay armed on review evidence that has since been withdrawn. Three repositories have run with the fix switched on since early October without problems, and the gate now runs from this repository, so the fix can apply everywhere through reviewed code instead of per-repository settings.
What
The organization-wide auto-merge gate now keeps every waiting evaluation by default, in arrival order. A repository or the whole organization can return to the old behaviour with one setting, and reusable-workflow callers keep their current behaviour.
Fixes #286
Part of #277
🤖 Generated with Claude Code