Skip to content

test(release): guard stable tag recovery decisions - #605

Merged
devantler merged 1 commit into
mainfrom
codex/stable-channel-proof-604
Oct 15, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/stable-channel-proof-604

Conversation

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Why

Safe recovery of an interrupted release depends on preserving the original tags and channel notes. That assumption needs lasting coverage before publication recovery is added.

What

Verify that existing stable releases need no channel-note repair and that a later fix selects the next patch. Cover both tag types and reject misleading results or changed files and refs; actual publication remains separate work.

Fixes #604
Part of #602

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Pre-submission correctness and simplification review is clean at d1513c82de36a60706861da0a11ae0a6669a279b, including a second independent read-only assessment. Two earlier test defects were corrected before publication: annotated-tag notes now bind to the captured commit and must appear in the native commit-note projection; the version oracle compares the complete version, rejecting both 1.2.50 and 1.2.5-beta.1 when expecting 1.2.5.

User-path evaluation ran the pinned Node 22 / semantic-release 25.0.3 command and shipped configuration in disposable file-only Git repositories. All eight stable/default-branch decisions pass. Eight native-output/ref/file mutation controls and the annotation-object regression are rejected for their intended diagnostics. The real reusable entrypoint executes the matrix, and its existing controls require observing completion.

All 14 maintenance checks, Bash lint, offline credential/source-boundary mutations, catalogue credential analysis, CI selection/reducer coverage, hardening and README parity pass. The host actionlint predates existing workflow features; its diagnostics are byte-identical at base and head, so it is not claimed as a passing syntax check. Hosted required CI remains pending. GitHub verifies the signed commit as valid.

The fixture omits only authenticated GitHub publication. These are executed dry-run decision and preservation receipts, not publication, original release-note reconstruction, prerelease or multiple-branch recovery evidence. #602/#603/#587 remain open for those outcomes.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b0af8696-e5e3-413a-b5fe-51b9597fcb6c
📥 Commits

Reviewing files that changed from the base of the PR and between 24a32fa and d1513c8.

📒 Files selected for processing: 9
  • .github/tests/create-release-fixture.sh
  • .github/tests/create-release-stable-channel-fixture.sh
  • .github/tests/test-create-release-fixture-controls.sh
  • .github/tests/test-create-release-offline.sh
  • .github/tests/test-create-release-stable-channels.sh
  • .github/workflows/ci.yaml
  • .github/workflows/create-release.yaml
  • AGENTS.md
  • README.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Review routing at d1513c82de36a60706861da0a11ae0a6669a279b: the authenticated CodeRabbit response, published 2026-10-15 18:23:10 UTC, says the included public-repository review allowance is exhausted and the next included review is available in 30 minutes. This is provider availability for this request, not a finding or a green review. No paid capacity or repeated request is used. Advancing to the next ordered lane, Codex, under the same head lock.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T18:27:39.960973Z d1513c8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: d1513c82de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-code-quality

github-code-quality Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: Go, C#

Go / code-coverage/test

main 24a32fa codex/stable-channel... d1513c8 +/-
50% 50% 0%

C# / code-coverage/dotnet

main 24a32fa codex/stable-channel... d1513c8 +/-
100% 100% 0%

Go / code-coverage/go

main 24a32fa codex/stable-channel... d1513c8 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated October 15, 2026 20:21 UTC

@devantler

devantler commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Ready at d1513c82de36a60706861da0a11ae0a6669a279b: the native Node 22 / semantic-release 25.0.3 stable-channel matrix passed all eight release decisions, including preservation checks. CI run 38784785720 has completed successfully, including the required aggregate. All readable head checks are successful or intentionally skipped.

The current-head Codex review is green. Complete review/comment/thread reads show no outstanding findings or maintainer direction, and the branch is conflict-free against the current base. The required-gate helper cannot independently observe the code-quality rule; GitHub currently reports CLEAN, and the ordinary protected merge remains authoritative.

Evaluation covers native release decisions and unchanged refs/files. Authenticated publication and consumer recovery remain tracked separately in #602/#603/#587.

After promotion, GitHub created an additional eligibility run 38803528586. At the final 2026-10-15 20:45 UTC read it remains queued with no runner assigned, so merge is pending that check. No check has failed. The bounded watcher was stopped; no unattended watcher remains from this run.

@devantler
devantler marked this pull request as ready for review October 15, 2026 20:37
@devantler
devantler merged commit 09299c9 into main Oct 15, 2026
288 checks passed
@devantler
devantler deleted the codex/stable-channel-proof-604 branch October 15, 2026 20:54
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Merged through ordinary protection at 09299c9d04e9ed4b7933bf7ae84692902846eed6, with reviewed PR head d1513c82de36a60706861da0a11ae0a6669a279b. The merged tree matches the validated candidate exactly. Executing the archived merged source with Node 22 and semantic-release 25.0.3 again passed all eight stable/default-branch decisions and preserved files and local/remote refs.

This completes #604. Authenticated publication, original note reconstruction, prerelease and multiple-branch recovery are not established by these decisions; #602/#603/#587 retain their separate acceptance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prove stable release recovery does not require channel-note rewrites

1 participant