Repository navigation
feat(rulesets): require the shared .NET tests on dotnet-template - #507
Conversation
Adds a managed organization rule that targets only dotnet-template and requires run-dotnet-tests.yaml from this repository's reviewed main, with no bypass. A render test pins the target, the workflow and the absence of a bypass; the managed inventory grows from five to six. Fixes #506 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai review |
✅ Action performedReview finished.
|
Code Coverage OverviewLanguages: Go, C# Go / code-coverage/testThe overall line coverage in commit bb4cd58 in the C# / code-coverage/dotnetThe overall line coverage in commit bb4cd58 in the Updated |
Evaluation at
What the rule will run. The shared .NET tests were exercised on the template itself in devantler-tech/dotnet-template#477: run 37363379803 passed on Ubuntu, Windows and macOS. The target id What this could not exercise. The rule has no effect until this repository's next release applies it, so there is nothing to run before merge. The trial called the workflow from a caller; the rule starts it directly, with no inputs. The first .NET template pull request after the release is the first observation of that shape, and devantler-tech/dotnet-template#424 stays open until it is seen. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (74)
🧰 Additional context used📚 Code guidelines (1)📓 Path-based instructions (2)Source excerpt: Every `.github/tests/test-*.sh` is a test entrypoint and must have an explicit invocation in a `ci.yaml` step's `run:` block.📄 CodeRabbit inference engine (AGENTS.md) Files:
Source excerpt: **Manage GitHub declaratively — never imperatively.**📄 CodeRabbit inference engine (AGENTS.md) Files:
🔇 Additional comments (7)
📝 WalkthroughWalkthroughThe change adds an active organization ruleset for the .NET template’s default branch. The ruleset requires the shared .NET tests workflow from the reviewed Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to No actionable issue is identified before merge. Confirm the effective rule after the publishing release as planned. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to The new gate references a different repository ID from the repository containing the reviewed workflow. This leaves the intended test enforcement and its security controls unconfirmed. Exposure is limited to the .NET template’s default branch, but reverting the deployment will not automatically remove an already-created gate. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Hardening Proposals
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (5 skipped: 5 unsupported.)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
The .NET template's pull requests run no build or test check on any platform, although its own instructions say one exists. The request to add it by hand (devantler-tech/dotnet-template issue 424) has waited three weeks, and organization rules can now be declared here instead, as was done for the Go template.
What
Adds a rule that applies only to the .NET template and requires the shared .NET tests on Ubuntu, Windows and macOS, taken from this repository's reviewed main branch. The existing hand-managed rule is left untouched, and nothing changes for any other repository.
Fixes #506
👉 After merge/promotion: the rule takes effect with the next release of this repository; the next .NET template pull request then shows the test checks. Merging this is the decision to add the gate — close it instead to keep the template on its lighter checks.