Skip to content

Roll out manual workflow-fix recovery and retire the opt-in #275

Open
1 of 1 issue completed
Open

Description

@devantler

🤖 Generated by the Agentic Engineer

Outcome

Adopt the default-off manual-workflow-fixes option introduced by devantler-tech/actions#1162 for devantler-tech/actions#703, then retire the temporary rollout flag after consumer evidence. Part of #287.

Acceptance criteria

  • Enumerate current lint.yaml and validate-go-project.yaml callers, their Actions pins, and artifact eligibility.
  • Opt in pilot callers after the shared fix is released, using pinned Actions revisions.
  • Record an eligible same-repository PR where a workflow-file formatter fix produces one complete downloadable patch, including related ordinary edits, without requesting workflow-write permission or attempting an automatic workflow-file commit.
  • Apply the downloaded patch in a clean checkout and verify its complete resulting tree.
  • Exercise a formatter fix together with an unfixable lint error: the patch remains downloadable, the lint job still fails, and no signer writes occur.
  • Verify omitted/false inputs preserve existing routing, ordinary fixes still sign, and fork, bot, read-only, and cancellation boundaries remain intact.
  • Roll out remaining consumers with their own review and CI evidence.
  • Change the default only after successful rollout, then remove the flag, concurrency discriminator, and obsolete flag-state fixtures while retaining recovery and authority coverage.

The flag remains false until rollout is validated. No consumer activation is implied by this task. Rough size: M.

Activity

  1. added theissue type on Sep 6, 2026
  2. moved this to 📥 Backlog in 🌊 Project Boardon Sep 6, 2026
  3. devantler commented on Sep 6, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    The shared recovery option is released in v13.4.1 at 36e6129f5fbbefb6f33816feaef04fb493575a43: https://github.com/devantler-tech/actions/releases/tag/v13.4.1 . Implementation devantler-tech/actions#1162 merged as d775642608de1145bb7f3a00ca6fc434caa23d61; its tree matches the fully reviewed and tested PR head.

    The release keeps manual-workflow-fixes false by default. Both hosted flag states passed, with 56 real patch-replay fixtures and 3,456 recovery/status/authority cases. Actual consumer activation and a hosted mixed lint-error/artifact recovery run remain the pilot acceptance work above. No consumer has been opted in by this release or this comment.

  4. transferred this issue fromon Sep 25, 2026
  5. devantler commented on Oct 4, 2026

    @devantler
    ContributorAuthor

    🤖 Generated by the Agentic Engineer

    PR #434 merged as 0600006 and repairs a rollout prerequisite: recovery exporters and coverage uploaders require their own helper checkout to have succeeded. A sibling or conditionally admitted composite checkout cannot establish that proof. The read-only workflow projection is regenerated from production source.

    The actual gate regression matrix rejects failed/skipped/cancelled installations while preserving successful manual patch recovery, ordinary signed fixes, read-only/fork/bot routing and cancellation behavior. Current-head native CI 37185393928 passes the Go and lint fixture paths with the complete recovery contracts. The promotion run also reports successful helper checkout before Go patch export and coverage upload.

    This is a delivered prerequisite, not consumer activation. The opt-in remains false. Eligible consumer PR artifact download/application, complete resulting-tree readback, the combined fixable/unfixable lint trial, remaining rollout and input retirement still belong to this issue.

    Declaration census: the complete public census at 2026-10-04 06:19:12 UTC found two explicit Go/lint calls and no nested callers. A narrow 08:12 UTC head/source rebind found:

    Caller Immutable pin Current recovery settings
    World at Ruin lint legacy Actions df7fd4f83edade31c121a9de563d9a7b9b1f900d (v13.10.3) manual option omitted/default false; apply-fixes false
    KSail ci-go canonical catalogue bd0035d (v4.9.4) manual option omitted/default false; apply-signed-fixes false

    Both declarations currently disable patch recovery. The manual option alone cannot override the independent fix/upload decision. A World at Ruin normal same-repository PR is the broader candidate after a separately reviewed canonical pin and both-input change. KSail additionally needs its caller allowlist predicate and a Go/lintable change to admit the formatter. Actual workflow-file formatter scope still requires consumer verification.

    The KSail default head advanced since the census, while its complete CI metadata blob remained 02b57f2fc693201179aa6d3472924f2b5350c74a; World at Ruin remained at its census head with CI blob 70b673a89039aca8ea6e0fa66101c93602a5e400. Organization-required invocations are policy configured and remain outside this declaration census. This observation is declaration eligibility only; native consumer mixed-error patch creation, download, clean replay, complete resulting-tree comparison and signer-no-write evidence remain outstanding.

    The complete promotion suite and required aggregation passed at reviewed head 0043c7e. v6.0.1 is published at the native merge commit. No caller activation is recorded by this delivery.

    Post-merge behavior readback: the Go recovery job records successful helper checkout before patch export, and the coverage job records successful helper checkout before upload. The lint manual-recovery path also passed. These observations do not claim the separate manual exporter replay fixture or a consumer pilot has run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Priority

    None yet

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions