Repository navigation
install-dkms: Don't build distro packages - #309
Merged
Merged
Conversation
dkms dropped mkrpm/mkdeb in 2.8.8. With set -e the failing command aborted the script after the module was installed, so it was never registered to load at boot or loaded. Other distros stopped at the same point with "unsupported distro". dkms install already installs the module, the packages were not used. Closes dev47apps#219
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219
Problem
install-dkmsbuilds a distro package afterdkms install:dkms removed
mkrpm/mkdebin 2.8.8. Because the script runs withset -e, the failing command aborts it right after the module is installed, so the steps that follow (registering the module to load at boot and loading it) never run. On distros other than Red Hat/Debian it already stopped at the same point with "unsupported distro".Fix
Remove the packaging step.
dkms installalready installs the module; the generated packages were never used by the script.