Skip to content

Miniature Navigation bar does not close after clicking a link #5

Open
Open
Miniature Navigation bar does not close after clicking a link#5
Labels
enhancementNew feature or requestgood first issueGood for newcomers

Description

@sigonasr2
sigonasr2
opened on May 1, 2019

The miniature pull-down navigation bar does not close once a link has been clicked. This means the user has to close it manually after selecting an option.

The small and larger versions of the navigation bar do not have this issue as they do not close/open.

Activity

  1. kevinfalting commented on May 5, 2019

    @kevinfalting
    kevinfalting
    on May 5, 2019
    Member

    This probably require some js that is listing for an onclick of each of the links that closes it.

  2. sigonasr2
    added a commit that references this issue on May 7, 2019

    Add in shadowing to make devOsan title stand out and readable. Made l…

    a17ed33
  3. kevinfalting
    assigned
    kevinfalting
    and
    sigonasr2
    and unassigned
    kevinfalting
    on May 8, 2019

  4. matthewjamesr commented on May 8, 2019

    @matthewjamesr
    matthewjamesr
    on May 8, 2019
    Member

    Reference this Vuejs code (func mobileMenu) as example to toggle the nav.

    https://matthewjamesr.gitlab.io/voodoo-vcp/

    https://matthewjamesr.gitlab.io/voodoo-vcp/js/index.js

  5. sigonasr2 commented on May 22, 2019

    @sigonasr2
    sigonasr2
    on May 22, 2019
    Author

    Pull Request #18 resolves this issue.

  6. kevinfalting
    added 3 commits that reference this issue on May 28, 2019

    Add in shadowing to make devOsan title stand out and readable. Made l…

    c4f30b9

    Created script to collapse menu. This is a fix for Issue #5

    3ba2ba6

    Merge pull request #18 from sigonasr2/collapsibleMenu-branch

    8f2eb87

  7. kevinfalting commented on May 28, 2019

    @kevinfalting
    kevinfalting
    on May 28, 2019
    Member

    The logo that links to the top of the page isn't closing the drawer, follow the same logic as the rest of the nav links.

  8. kevinfalting
    added
    enhancementNew feature or request
    good first issueGood for newcomers
    on May 28, 2019
  9. kevinfalting
    unassigned
    sigonasr2
    on May 28, 2019
  10. kevinfalting
    added a commit that references this issue on May 28, 2019

    Merge pull request #10 from sigonasr2/collapsibleMenu-branch

    b2b09f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions