Repository navigation
Conversation
|
Wi-Fi at boot on the 9a, nice work, and thank you for the ping and scan numbers. I merged 0.2.1 to 0.2.3 through #235, so this needs a rebase onto main (0.2.4 on top of 0.2.3). Before I merge it, could you post a Two small things, neither blocking: the graphics unit runs before the display manager and Wi-Fi is its last step, so a failing Wi-Fi bring-up can hold the login screen back by up to about 35 s; a separate unit after the display manager would avoid that someday. And one README line saying that a hang in the Wi-Fi step also keeps the GPU and display off on the next boot (the single marker) would help someone reading a bad boot. |
With the zumapro PCIe channel-1 host and the Wi-Fi node in the device tree, the graphics start loads pcie_zumapro, waits for the BCM4383 on the link, then loads brcmfmac and waits for its interface, as hang-safe steps after NFC.
… a Wi-Fi hang keeps the display off too Review of derekross#238: the graphics start's one marker covers every step, so a hang in the Wi-Fi step leaves the GPU and the display off on the next boot as well.
760d181 to
f86c663
Compare
|
Rebased onto main (0.2.4 on top of your 0.2.3), and the README now says that a hang in the Wi-Fi step leaves the one marker, so the GPU and the display stay off on the next boot too. It also names the Wi-Fi step in the table. After the rebase, the only package change from what's installed on the palmtop is that README text; the scripts are byte-identical. The boot:
One correction to the evidence: the 10-31 boot of this same kernel had two oopses in brcmfmac's scan handler, and its smoke report (on #168) said "4 oops/BUG". The smoke report from this boot: phone-smoke: teguKernel
Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-audio 0.5.6-1, omamobile-device-tegu 0.2.4-1, omamobile-fingerprint 0.1.8-1, omamobile-firstboot 0.1.0-1, omamobile-gnss 0.2.5-1, omamobile-keyring 20261013-1, omamobile-mirror 0.1.1-1, omamobile-modem 0.1.4-1, omamobile-modem-sit 0.3.3-1, omamobile-omarchy 0.1.23-1, omamobile-owl-widgets 0.1.1-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.62-1, omarchy 4.0.6-1 Bluetooth, sound, sensors and cameras are skipped or failing because this DTB is the stack only up to the charger plus Wi-Fi. The three failed units aren't from the package: two are bring-up units on the palmtop looking for nodes later PRs add, and |
|
Thanks for the rebase, the README line about the single marker, and the smoke report from this head. It's also good that you caught the scan-handler oops from the 10-31 boot and fixed it in brcmfmac as its own commit. I found one thing that would keep Wi-Fi off on every 9a but yours. The step only runs when this file exists: wifi_fw=$root/usr/lib/firmware/brcm/brcmfmac4383-pcie.binBut Could you point the check at the file the extractor installs? wifi_fw=$root/usr/lib/firmware/updates/brcm/brcmfmac4383-pcie.google,zumapro-tegu.binOr accept that path or the same name without The rest reads well:
One note for the merge order: this needs kernel #168 for the host's node and #227 for |
…e host when the device tree has it Kernel derekross#168's standalone host is being replaced by derekross#178, which puts the 9a's channel 1 on derekross#156's pcie_gs201 and phy_zuma_pcie. The graphics start picks the host from the node's compatible, and both new modules are kept out of autoload like the old one.
|
Thanks for moving this to the shared zuma-family host so quickly. Choosing the host from the node's compatible and keeping the old module as the fallback is a clean way to cover both kernels, and the test covers both, including a failed PHY load. The point from my last comment still stands, though. Line 49 still gates Wi-Fi on the generic name: wifi_fw=$root/usr/lib/firmware/brcm/brcmfmac4383-pcie.bin
Two notes on the new commit, neither blocking:
When this merges, I'll also update the title, since the host is no longer only the zumapro one. |
…ractor installs tools/extract-vendor-firmware and tools/phone-provision install only updates/brcm/brcmfmac4383-pcie.google,zumapro-tegu.bin, so the check on the generic brcmfmac4383-pcie.bin skipped Wi-Fi on a palmtop set up by our tools. The test creates the board file instead.
|
Fixed in 84b1e34: the check now looks for The boot you asked for, today on the palmtop with kernel #178 (
|
|
Landed on main as c5795a8 (squashed, authored by you). My review notes from before the merge, for the record: Thank you for the fix and for the boot. Keying on I'll merge this first and #275 right after it, so this one keeps 0.2.4 and #275 lands as 0.2.5. Since the host is no longer only the zumapro one, I'll use "omamobile-device-tegu 0.2.4: Wi-Fi at boot through the zuma-family PCIe host" as the subject and write the merged message from the current code, because the description still describes #168's One note for later, not for this PR: #168's driver has been superseded by #178, and our kernel config dropped |
…ing (#307) The 9a's row after today's merges, with a NOTES entry for the evening's boots that the new cells link to. - **Wi-Fi, testing to works.** `omamobile-device-tegu` 0.2.4 (#238) starts it at boot now, through the shared gs201 host and zuma PHY (kernel #178 on #156, both in review) and brcmfmac (kernel #56, in review), with only the extractor's firmware. The NOTES entry has the boot, and the three rebinds with Bluetooth up after #178's FLR commit. The kernel parts are still in review, and the cell says so, as the display cells did. - **Suspend, WIP to testing.** The power key now lights the lock screen on the first press (#268, #275). Thirty attended sleeps and a day of real use with auto-sleep on all woke (SLEEP-PLAN, #284). The cell still says that three test sleeps on 10-28 to 10-30 never woke and that sleep tests stay attended. If you'd rather keep WIP until that hang is understood, I'll revert just the word. - **Display:** the display DT is merged, and brightness, DPMS off and on and the 60/120 Hz switch now have a dated record (kernel #125's boot, which also checks the panel ID). - **Charging, Haptics, Torch, NFC:** kernel #161, #96, #104 and #105 are merged. - **USB net:** the rescue also handles a replug the gadget didn't see (#280). The NOTES entry lists each boot with its release: Wi-Fi from the package, the power-key wake, the replug, storage idle (kernel #99), the panel ID (kernel #125), the RTC without the PMIC interrupt (kernel #55), and the auto-sleep day. GNSS and Modem stay as they are until the SIM test on Tuesday. Docs only; `tools/pr-check` passes, and the diff has no identifiers. Closes #307 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Stacked on #235 (0.2.3), #234 (0.2.2) and #230 (0.2.1); the fourth commit is this one.
With linux-omarchy-mobile#168 the 9a's device tree has the zumapro PCIe channel-1 host and the Wi-Fi node. The graphics start gains a last hang-safe step for it:
modprobe pcie_zumapro. Its probe brings the link up.0000:01:00.0.modprobe brcmfmac, and wait for awl*interface.The step only runs when the host's node (
13120000.pcie), thewifi-dma-poolreserved memory and the owner'sbrcmfmac4383-pcie.binare all there. Otherwise it logs a skip, so the palmtop's daily integration boot (nopcie_zumaproin that tree) is unaffected. Each failure is logged and skipped, and the marker is cleared, as for the other steps. Both modules were already blacklisted inomamobile-tegu-guards.conf, whose comment now says the graphics start loads them. The test covers the order, the summary, and a failed host load that must not load brcmfmac.Tested on the palmtop today with #168's kernel (and brcmfmac as at linux-omarchy-mobile#56) and this package. At boot, with nothing by hand:
wlan0up and connected through NetworkManager, with 8 networks in the scan.wlan0at 18 ms.test/allandtools/pr-checkpass.