Pass experiments and set PACKAGE_MANAGER env variable on proxy - #656
Open
AbhishekBhaskar wants to merge 3 commits into
Open
Pass experiments and set PACKAGE_MANAGER env variable on proxy#656AbhishekBhaskar wants to merge 3 commits into
PACKAGE_MANAGER env variable on proxy#656AbhishekBhaskar wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR forwards
experimentsandPACKAGE_MANAGERto the proxy.What
Enables the CLI to drive the proxy's upcoming egress allowlist feature by:
experimentsinto the proxy config (so toggles likeproxy_egress_observe/proxy_egress_enforcecan be flipped locally).PACKAGE_MANAGERenv var on the proxy container (so it loads the correct per-ecosystem allowlist defaults).Why
Part of the
Egress Allowlist in Proxyepic. The CLI previously only passedall_credentials+cato the proxy, so the egress toggles couldn't be exercised via the CLI, andPACKAGE_MANAGERwas empty — which would degrade the allowlist to GitHub-infra-only under enforce.Changes
internal/infra/config.go: addExperiments model.Experiment(json:"experiments,omitempty") to the proxyConfig.internal/infra/proxy.go: populateproxyConfig.Experimentsfromparams.Job.Experiments; addPACKAGE_MANAGER=<job.PackageManager>inproxyEnv().internal/infra/proxy_test.go: updateproxyEnvcall sites for the new signature and add aPACKAGE_MANAGERtest.Testing
go build ./...andgo test ./internal/...pass.dependabot update -f job.ymlthat a job'sexperimentsblock reaches the proxy config andPACKAGE_MANAGERis set on the container.