mixing: Validate RS hashes during blame assignment - #3760
Open
jholdstock wants to merge 1 commit into
Open
Conversation
Member
|
This looks necessary but we should be stricter about it. If a RS message references both junk and a valid RS message, we should similarly treat the peer as misbehaving, rather than permitting them because at least one of the hashes was valid. |
Ensuring that the RS hashes from rs.SeenSecrets actually exist in the current session closes a loophole where a peer could escape blame by simply filling rs.SeenSecrets with junk in order to bypass the len!=0 check.
jholdstock
force-pushed
the
validate-rs
branch
from
August 12, 2026 02:13
1ba27a7 to
9fbb708
Compare
Member
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensuring that the RS hashes from rs.SeenSecrets actually exist in the current session closes a loophole where a peer could escape blame by simply filling rs.SeenSecrets with junk in order to bypass the len!=0 check.