Repository navigation
Review pages where ansible_ssh_user is still in use #251
Description
Since Ansible 2.0 and higher where ansible_ssh_user is deprecated and replaced by ansible_user [tallandtree_]
Search: https://docs.debops.org/en/latest/search.html?q=ansible_ssh_user&check_keywords=yes&area=default
Activity
AnBuKu commentedon Jul 22, 2017
Should I re-work the pages one by one? I'll happily do it, up to you :-)
s/ansible_ssh_user/ansible_user/g;
ypid commentedon Jul 22, 2017
I added the substitution to
debops-optimizeso this fix will propagate over time. You can rework roles if you like. Ideally you can ask which roles would be suitable. Maybe checkoutdebops.atdif you like. That one should be easy.AnBuKu commentedon Jul 22, 2017
Did this one right now: https://github.com/debops/ansible-atd/pull/9
How do I ask? @ypid makes me a list and work on that or I follow this: Search: https://docs.debops.org/en/latest/search.html?q=ansible_ssh_user&check_keywords=yes&area=default
ypid commentedon Jul 22, 2017
https://docs.debops.org/en/latest/search.html?q=ansible_ssh_user&check_keywords=yes&area=default should be ok for this case when you only want to update the variable. I am just not sure if the DebOps Developers could not do this more conveniently when reworking roles anyway. Ideally you would search for all occurances of
ansible_ssh_user(not just in the docs, but also in the actualcode).AnBuKu commentedon Jul 22, 2017
OK, I'll go for your proposal, docs and code + min_ansible_version: '1.9.0' -> min_ansible_version: '2.0' + if needed - name: Debian versions: - wheezy - jessie add - stretch. - Or do I forget about stretch for the moment?
ypid commentedon Jul 22, 2017
When you have tested that the role actually works with stretch why not. I would not just add it just for the sake of it :)
AnBuKu commentedon Jul 22, 2017
True, so I'll leave it in the future (one is already done without testing on stretch) without stretch.
AnBuKu commentedon Jul 22, 2017
@ypid Please, feel free to update/change. If you agree I start to work off the bullet list below.
Next, after debops/ansible-atd are (change to
ansible_userand/or to version `2.0.0 as a consequence):debops/ansible-role-ansible
debops/ansible-bootstrap
debops/ansible-debops
debops/ansible-kvm - Deprecated role
debops/ansible-librenms
debops/ansible-libvirtd
debops/ansible-openvz
debops/ansible-preseed
debops/ansible-smstools
[-]Review 19 pages where ansible_ssh_user is still in use[/-][+]Review pages where ansible_ssh_user is still in use[/+]ypid commentedon Jul 22, 2017
Looks good to me. But keep in mind that you can automate most of the work when you want to get a little fancy :) Still some changelog stuff and other things might have to be done manually. I thought for a sec that we deprecated
debops.openvzalready but seems it it still supported so go for it :)AnBuKu commentedon Jul 22, 2017
I'm pretty sure you as a hacker/coder can automate this replacement work. :-) - But not me as Joe Average or a simple supporter. I would spend much more time for automation, than update 25 files. :-(
debops.openvzis one of 20 roles with status tagbuild failingof actual 122 DebOps roles. In this status table there is no role with statusdeprecated, maybe as there is no column with statusactiveordeprecated.ypid commentedon Jul 22, 2017
All right.
Deprecated disappear from the status page currently. I think there is an issue for status field. It has been requested a number of times but I am not really convinced :)
AnBuKu commentedon Jul 22, 2017
Maybe at the end of the status page, there could be a section
Deprecated roles? As well, the tagDeprecated rolewould need to be applied in GitHub and in docs.debops.org, short: At any place related to the deprecated role, so DebOps users see clearly without searching, that the role is deprecatedAnyhow, for the moment being, I'm not aware of any deprecated role in DebOps.
ypid commentedon Jul 23, 2017
Lets just say I am not convinced that this should be on my todo right now :)
There are some.
grepover all roles helps.AnBuKu commentedon Jul 23, 2017
Don't worry, I don't wanna convince you of anything :)
Then following your
grepover all roles there are so far two deprecated roles (maybe more?)Still listed in the DebOps status page. Both roles with Warning, this is a deprecated role It has been superseded by blabla. - So far fine and correct.
What's for me a bit uncool, is the statement at the beginning of the status page:
What is somehow not true, as two of the 122 are deprecated.
And as a newbie to DebOps, clicking by chance on the debops/ansible-mysql and then reading the warning, you feel very likely somehow mucked.
ypid commentedon Jul 23, 2017
@drybjed I guess those roles should be removed from debops/docs?
AnBuKu commentedon Jul 23, 2017
Or at least removed from the status page; as long there is no column (Deprecated y/n) or section "Deprecated roles" at the end of the status page. The latter, at the end of the page, I would prefer, as it doesn't blow up the role table.
Both might make sense, as documentation of such circumstances might be asked by Best Practice Badge of CII. But I'm not sure about that.
ypid commentedon Jul 23, 2017
Removing from debops/docs will also remove them from the status page.
AnBuKu commentedon Jul 23, 2017
Hmmm... what is your suggestion then?
I mean, above you asked (and I supported)
ypid commentedon Jul 23, 2017
Removing from both for now. They can still be found on GitHub.
AnBuKu commentedon Jul 24, 2017
If we do so, I suggest to open an issue "Status page / Deprecated rolls" in github debops/docs as a reminder. Including layout of (far in the) future "status page".
Status page
|
|__Active
| |__Core rolls
| |__Community packages
|
|__Deprecated