Skip to content

Signature calc with __TMP_FOLDER - #13

Merged
dealfonso merged 1 commit into
dealfonso:mainfrom
malamalca:main
Apr 20, 2022
Merged

dealfonso merged 1 commit into
dealfonso:mainfrom
malamalca:main

Conversation

@malamalca

Copy link
Copy Markdown
Contributor

PHP 8 does not like creating temporary files in system's temp folder. A notice is issued: "tempnam(): file created in the system's temporary directory".
This fix passes existing constant __TMP_FOLDER to PDFUtilFnc::calculate_pkcs7_signature() function. This fix prevents the notice above.

PHP 8 does not like creating temporary files in system's temp folder. A notice is issued: "tempnam(): file created in the system's temporary directory".
This fix passes existing constant __TMP_FOLDER to PDFUtilFnc::calculate_pkcs7_signature() function. This fix prevents the notice above.
@dealfonso

Copy link
Copy Markdown
Owner

Hi,

first of all, thank you for detecting the problem.

Now, before accepting the merge, it seems that __TMP_FOLDER is not defined anywhere, so it raises an error:

image

So please fix it (by including a default definition to (e.g.) /tmp).

Thank you

@dealfonso dealfonso self-assigned this Apr 20, 2022
@dealfonso dealfonso added the bug Something isn't working label Apr 20, 2022
@malamalca

Copy link
Copy Markdown
Contributor Author

The constant definition is a part of base class.

if (!defined('__TMP_FOLDER'))

@dealfonso

Copy link
Copy Markdown
Owner

Hi,

you are right. Sorry for not double-checking it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants