Repository navigation
Signature calc with __TMP_FOLDER - #13
Merged
Merged
Conversation
PHP 8 does not like creating temporary files in system's temp folder. A notice is issued: "tempnam(): file created in the system's temporary directory". This fix passes existing constant __TMP_FOLDER to PDFUtilFnc::calculate_pkcs7_signature() function. This fix prevents the notice above.
Owner
Contributor
Author
|
The constant definition is a part of base class. Line 52 in 7251b0f |
Owner
|
Hi, you are right. Sorry for not double-checking it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PHP 8 does not like creating temporary files in system's temp folder. A notice is issued: "tempnam(): file created in the system's temporary directory".
This fix passes existing constant __TMP_FOLDER to PDFUtilFnc::calculate_pkcs7_signature() function. This fix prevents the notice above.