Dbeaver/pro#10606 data dam api for desktop - #2
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new module uses eclipse-plugin packaging but configures maven-surefire-plugin, which risks tests not being executed (or being executed incorrectly) in a Tycho-based build.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces a new com.dbeaver.datadam.share.api Eclipse plug-in module to the DataDam API set, adding a public Share/Project API surface (service interface + models) and a deterministic fingerprint/revision utility intended for desktop clients.
Changes:
- Registers the new
com.dbeaver.datadam.share.apimodule in the aggregatedapisbuild. - Adds Share API public types (
DDProjectService, project/config/revision/update models, andDDShareException). - Implements
DDFingerprintUtils(SHA-256, versioned, length-delimited hashing) with JUnit 5 coverage.
File summaries
| File | Description |
|---|---|
| apis/pom.xml | Adds the new Share API module to the multi-module build. |
| apis/com.dbeaver.datadam.share.api/pom.xml | Declares the new Eclipse plug-in artifact and its test dependencies/build plugins. |
| apis/com.dbeaver.datadam.share.api/META-INF/MANIFEST.MF | OSGi metadata exporting Share API packages. |
| apis/com.dbeaver.datadam.share.api/build.properties | PDE build inputs/outputs for the new plug-in. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/service/DDProjectService.java | Defines the Share API service contract for project CRUD and push/pull operations. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDProject*.java | Adds project/config/file/revision/history/update-type public DTOs. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/exception/DDShareException.java | Adds Share API checked exception type. |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/utils/DDFingerprintUtils.java | Adds stable, versioned fingerprint + revision hashing utility. |
| apis/com.dbeaver.datadam.share.api/src/test/java/com/dbeaver/datadam/share/api/utils/DDFingerprintUtilsTest.java | Adds unit tests asserting stable fingerprint/revision format and behavior. |
Review details
- Files reviewed: 14/14 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
serge-rider
requested changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes dbeaver/pro#10606