dbeaver/pro#10296 Add gateway protocol API module - #1
Merged
alexander-skoblikov merged 4 commits intoSep 9, 2026
Merged
Conversation
…nfiguration-ofproject-share # Conflicts: # apis/pom.xml
There was a problem hiding this comment.
🟡 Changes recommended
Newly added files use inconsistent licensing headers and introduce API models with ID/time types that are inconsistent with the existing module’s strongly-typed conventions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds new DataDam Share API model types to support creating/updating “configuration” entities (including configuration parts) as part of the gateway protocol API surface.
Changes:
- Added request/response DTOs for creating and updating configurations (
DDCreateConfiguration*,DDUpdateConfiguration*). - Added configuration domain model records (
DDConfiguration,DDConfigurationSummary,DDConfigurationPart,DDConfigurationPartKind).
File summaries
| File | Description |
|---|---|
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDUpdateConfigurationResult.java | Adds update response DTO returning updated configuration and conflicting keys |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDUpdateConfigurationRequest.java | Adds update request DTO with expected configuration version and parts list |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDUpdateConfigurationPartRequest.java | Adds per-part update request DTO (key, expected version, encrypted value) |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDCreateConfigurationRequest.java | Adds create request DTO (name + parts) |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDCreateConfigurationPartRequest.java | Adds per-part create request DTO (key, kind, optional project id, encrypted value) |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDConfigurationSummary.java | Adds lightweight configuration summary DTO |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDConfigurationPartKind.java | Adds enum for configuration part kind (ACCOUNT/PROJECT) |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDConfigurationPart.java | Adds configuration part DTO (key/kind/project/version/encrypted value) |
| apis/com.dbeaver.datadam.share.api/src/main/java/com/dbeaver/datadam/share/api/model/DDConfiguration.java | Adds full configuration DTO (id/name/version/timestamps/parts) |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 13
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alexander-skoblikov
approved these changes
Sep 9, 2026
alexander-skoblikov
deleted the
dbeaver/pro#10296-Configuration-ofproject-share
branch
September 9, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.